Audit tko/parse: Fail-hard on parsing errors |
||||
Issue descriptionThis is a follow up mitigation bug from go/chops-pm-104 That outage would have been avoided if the bug in tko/parse had been caught in staging. staging tests would have caught the bug if tko/parse had failed on the failure instead of reporting corrupted data. tko/parse often tries to "make progress" by reporting some data. The ask here is - in particular: make tko/parse fail on the particular problem that caused that outage. - audit tko/parse for other instances of defensive programming and make it fail in all those instances.
,
Nov 30
PM follow up ==> default P1
,
Nov 30
,
Nov 30
Let's make sure lucifer fails if tko/parse fails.
,
Dec 3
Clarify: we only want to hard fail on tko export part of tko/parse, not on the other pipeline exports.
,
Dec 3
Re #4, Lucifer exits non-zero if parse exits non-zero. This should be considered a failure by the Swarming suite wait task.
,
Dec 13
In my first pass through the code, I'm not finding anywhere where we squelch an exception.
,
Jan 7
I took a look, didn't find anything to act on. |
||||
►
Sign in to add a comment |
||||
Comment 1 by pprabhu@chromium.org
, Nov 30