DevTools: remove outdated debugging UI |
|||
Issue descriptionA few pieces of DevTools UI were added to aid debugging, but may now be obsolete. We should validate these and remove if appropriate: - When debugger is paused, the inspected page is overlaid with a gray/transparent background, "Continue" button, and "Step over" button. The "Step over" button does not make much sense when source code is not visible. - Double clicking an Object's property (Scope, Watches, Objects in Console) allows users to edit the property value. In Sources panel, the "Watch expressions" sidepane on the right allows adding watches. There are a couple issues - The "minus" sign is used nowhere else in DevTools. We could align it to match the 'x's in Console's live expressions - Clicking the "minus" to delete an expression sometimes fails when overlay scrollbars get in the way (esp. on M
,
Nov 30
,
Dec 1
julia@, here's a screenshot proposing changes to the Watch expressions' minus sign, does this seem fine? https://imgur.com/a/pdrKIey
,
Dec 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de56e6ad7b3aa2383e8279b6abc25087ed0652b5 commit de56e6ad7b3aa2383e8279b6abc25087ed0652b5 Author: Erik Luo <luoe@chromium.org> Date: Mon Dec 03 23:18:47 2018 DevTools: remove old minus icon in watches - Avoid showing scrollbar when creating new watch - Fix object watch alignment - Replace "minus" icon with "cross" Screenshot: https://imgur.com/a/pdrKIey Bug: 910683 Change-Id: I554f08295a4c92c954167f5e09f55f104d285bfb Reviewed-on: https://chromium-review.googlesource.com/c/1357602 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#613310} [modify] https://crrev.com/de56e6ad7b3aa2383e8279b6abc25087ed0652b5/third_party/blink/renderer/devtools/BUILD.gn [delete] https://crrev.com/a05b0a5cf5c75339c805aed399007b11e302c729/third_party/blink/renderer/devtools/front_end/Images/deleteIcon.png [modify] https://crrev.com/de56e6ad7b3aa2383e8279b6abc25087ed0652b5/third_party/blink/renderer/devtools/front_end/sources/WatchExpressionsSidebarPane.js [modify] https://crrev.com/de56e6ad7b3aa2383e8279b6abc25087ed0652b5/third_party/blink/renderer/devtools/front_end/sources/watchExpressionsSidebarPane.css
,
Dec 11
Looks good as is. We are hoping that the distance between the scrollbar and 'x' could be decreased, but if this is tricky, it's ok as is. Thank you!
,
Dec 12
The 'Step over' button has been there since 2013, introduced in issue 247632 . During the UX audit, we didn't see much sense in having it there. dgozman@, is there a use case/need for it?
,
Dec 12
|
|||
►
Sign in to add a comment |
|||
Comment 1 by l...@chromium.org
, Nov 30