New tab button clicks aren't being logged in Split Toolbar (Duet) |
|||||||
Issue descriptionChrome Version: All versions OS: Android We are not recording user actions for new tab button clicks when split toolbar is enabled.
,
Dec 6
,
Dec 6
Realized this didn't make branch cut.
,
Dec 7
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 7
Pls merge your change to M72 branch 3626 ASAP so we can pick it up for next Dev & Beta release. Thank you.
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22d3140e4ad60b6a4383cc5bd85970d49fec45b8 commit 22d3140e4ad60b6a4383cc5bd85970d49fec45b8 Author: Pedro Amaral <amaralp@chromium.org> Date: Fri Dec 07 20:06:50 2018 Move new tab UMA logging to the click handler Previously the logging was done in ToolbarPhone. This meant that Duet wasn't logging any of the new tab button clicks. This moves the logging to the click handler. TBR=amaralp@chromium.org (cherry picked from commit 2e2b4baa079a37fda7a0f31196de4f64325f13e8) Bug: 910682 Change-Id: I318ccdeffdb453e97cca8e3a203177b5db2f1791 Reviewed-on: https://chromium-review.googlesource.com/c/1357381 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612855} Reviewed-on: https://chromium-review.googlesource.com/c/1368605 Reviewed-by: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#148} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/22d3140e4ad60b6a4383cc5bd85970d49fec45b8/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/22d3140e4ad60b6a4383cc5bd85970d49fec45b8/chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java
,
Dec 7
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22d3140e4ad60b6a4383cc5bd85970d49fec45b8 Commit: 22d3140e4ad60b6a4383cc5bd85970d49fec45b8 Author: amaralp@chromium.org Commiter: amaralp@chromium.org Date: 2018-12-07 20:06:50 +0000 UTC Move new tab UMA logging to the click handler Previously the logging was done in ToolbarPhone. This meant that Duet wasn't logging any of the new tab button clicks. This moves the logging to the click handler. TBR=amaralp@chromium.org (cherry picked from commit 2e2b4baa079a37fda7a0f31196de4f64325f13e8) Bug: 910682 Change-Id: I318ccdeffdb453e97cca8e3a203177b5db2f1791 Reviewed-on: https://chromium-review.googlesource.com/c/1357381 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612855} Reviewed-on: https://chromium-review.googlesource.com/c/1368605 Reviewed-by: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#148} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Nov 30