Issue metadata
Sign in to add a comment
|
Build failures with llvm-next (r346389) |
||||||||||||||||||||||||
Issue descriptionTwo packages power_manager and drivefs fail to build because of same type of error: power_manager-0.0.2-r2911: armv7a-cros-linux-gnueabihf-clang++ -MMD -MF obj/power_manager/powerd/system/libsystem.arc_timer_manager.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -DUSE_BUFFET=false -Igen/include -I../../../../../../../../../../mnt/host/source/src/platform2 -I/build/bob/usr/include -Wall -Wno-psabi -Wunused -Wno-unused-parameter -ggdb3 -fstack-protector-strong -Wformat=2 -fvisibility=internal -Wa,--noexecstack -Werror --sysroot=/build/bob -fPIE -DUSE_RTTI_FOR_TYPE_TAGS -Wno-c++11-extensions -Wno-unused-local-typedefs -DBASE_VER=395517 -pthread -I/build/bob/usr/include/chromeos -I/build/bob/usr/include/base-395517 -I/build/bob/usr/include/glib-2.0 -I/build/bob/usr/lib/glib-2.0/include -I/build/bob/usr/include/nss -I/build/bob/usr/include/nspr -I/build/bob/usr/include/dbus-1.0 -I/build/bob/usr/lib/dbus-1.0/include -I/build/bob/usr/include/chromeos -std=gnu++14 -DVCSID=\"0.0.2-r2911-763e67284e2b5dcd206030111bb94c413624c9f7\" -DNDEBUG -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O2 -pipe -march=armv8-a+crc -mtune=cortex-a57.cortex-a53 -mfpu=crypto-neon-fp-armv8 -mfloat-abi=hard -g -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -c ../../../../../../../../../../mnt/host/source/src/platform2/power_manager/powerd/system/arc_timer_manager.cc -o obj/power_manager/powerd/system/libsystem.arc_timer_manager.o power_manager-0.0.2-r2911: ../../../../../../../../../../mnt/host/source/src/platform2/power_manager/powerd/system/arc_timer_manager.cc:80:3: error: explicitly defaulted default constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted] power_manager-0.0.2-r2911: ArcTimerInfo() = default; power_manager-0.0.2-r2911: ^ power_manager-0.0.2-r2911: ../../../../../../../../../../mnt/host/source/src/platform2/power_manager/powerd/system/arc_timer_manager.cc:90:19: note: default constructor of 'ArcTimerInfo' is implicitly deleted because field 'clock_id' of const-qualified type 'const clockid_t' (aka 'const int') would not be initialized power_manager-0.0.2-r2911: const clockid_t clock_id; power_manager-0.0.2-r2911: ^ power_manager-0.0.2-r2911: ../../../../../../../../../../mnt/host/source/src/platform2/power_manager/powerd/system/arc_timer_manager.cc:81:3: error: explicitly defaulted move constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted] power_manager-0.0.2-r2911: ArcTimerInfo(ArcTimerInfo&&) = default; power_manager-0.0.2-r2911: ^ power_manager-0.0.2-r2911: ../../../../../../../../../../mnt/host/source/src/platform2/power_manager/powerd/system/arc_timer_manager.cc:93:24: note: move constructor of 'ArcTimerInfo' is implicitly deleted because field 'expiration_fd' has a deleted move constructor power_manager-0.0.2-r2911: const base::ScopedFD expiration_fd; power_manager-0.0.2-r2911: ^ power_manager-0.0.2-r2911: ../../../../../../../../usr/include/base-395517/base/scoped_generic.h:57:47: note: 'ScopedGeneric' has been explicitly marked deleted here power_manager-0.0.2-r2911: DISALLOW_COPY_AND_ASSIGN_WITH_MOVE_FOR_BIND(ScopedGeneric) power_manager-0.0.2-r2911: ^ power_manager-0.0.2-r2911: 2 errors generated. drivefs-0.0.1-r142: armv7a-cros-linux-gnueabihf-clang++ -MMD -MF platform/drivefs/libdrivefs.ipc_server.o.d -DAPISERVING_USE_PRIVATE_STATUS -DGOOGLECLIENT_SUBSET -DGLOG_NO_ABBREVIATED_SEVERITIES -DDISABLE_GOOGLE_STRING -DHAVE_GETADDRINFO -DGUNIT_NO_GOOGLE3 -DOPENSOURCE_PROTOBUFS -DOS_CHROMEOS -DOS_LINUX -DGOOGLE_UNSUPPORTED_OS_LOONIX -DTHIRD_PARTY_ABSL_BASE_BASE_CONFIG_H_ -DPORTABLE_BASE -DUSE_FAKE_DRIVEFS_LAUNCHER=0 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -I/build/bob/usr/include/drivefs -I../../../drivefs-0.0.1/platform/drivefs -Iplatform/drivefs/libdrivefs.gen/include -Igen/include -I/build/bob/tmp/portage/chromeos-base/drivefs-0.0.1-r142/work/drivefs-0.0.1/platform2 -I/build/bob/usr/include -Wall -Wno-psabi -Wunused -Wno-unused-parameter -ggdb3 -fstack-protector-strong -Wformat=2 -fvisibility=internal -Wa,--noexecstack -Werror --sysroot=/build/bob -DUSE_RTTI_FOR_TYPE_TAGS -Wno-cast-qual -Wno-cast-align -Wno-c++11-extensions -Wno-unused-local-typedefs -DBASE_VER=395517 -pthread -I/build/bob/usr/include/chromeos -I/build/bob/usr/include/libmojo-395517 -I/build/bob/usr/include/base-395517 -I/build/bob/usr/include/glib-2.0 -I/build/bob/usr/lib/glib-2.0/include -I/build/bob/usr/include/nss -I/build/bob/usr/include/nspr -I/build/bob/usr/include/dbus-1.0 -I/build/bob/usr/lib/dbus-1.0/include -fPIE -std=gnu++14 -DNDEBUG -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O2 -pipe -march=armv8-a+crc -mtune=cortex-a57.cortex-a53 -mfpu=crypto-neon-fp-armv8 -mfloat-abi=hard -g -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -c ../../../drivefs-0.0.1/platform/drivefs/ipc_server.cc -o platform/drivefs/libdrivefs.ipc_server.o drivefs-0.0.1-r142: In file included from ../../../drivefs-0.0.1/platform/drivefs/ipc_server.cc:7: drivefs-0.0.1-r142: In file included from ../../../../../../../../usr/include/drivefs/apps/drive/fs/chromeos_core_client.h:15: drivefs-0.0.1-r142: In file included from ../../../../../../../../usr/include/drivefs/apps/drive/fs/core/file_system_bridge.h:14: drivefs-0.0.1-r142: In file included from ../../../../../../../../usr/include/drivefs/apps/drive/fs/core/stream/cello_fs.h:33: drivefs-0.0.1-r142: In file included from ../../../../../../../../usr/include/drivefs/apps/drive/fs/core/stream/change_replayer.h:21: drivefs-0.0.1-r142: ../../../../../../../../usr/include/drivefs/apps/drive/fs/core/stream/entry_cache.h:142:10: error: explicitly defaulted move assignment operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted] drivefs-0.0.1-r142: Entry& operator=(Entry&&) = default; drivefs-0.0.1-r142: ^ drivefs-0.0.1-r142: ../../../../../../../../usr/include/drivefs/apps/drive/fs/core/stream/entry_cache.h:155:17: note: move assignment operator of 'Entry' is implicitly deleted because field 'version_counter_' is of const-qualified type 'const int64_t' (aka 'const long long') drivefs-0.0.1-r142: const int64_t version_counter_;
,
Nov 30
So far nothing related to lld since I have not enabled lld in my local testing.
,
Dec 1
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/e41b7bad1c3867b5bdf10b8d94cd5fec3d99c79b commit e41b7bad1c3867b5bdf10b8d94cd5fec3d99c79b Author: Manoj Gupta <manojgupta@google.com> Date: Sat Dec 01 09:08:46 2018 power_manager: Fix errors reported by newer llvm version. Aggregates with const members can't have defaulted constructors. Fixes error: platform2/power_manager/powerd/system/arc_timer_manager.cc:80:3: error: explicitly defaulted default constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted] power_manager-0.0.2-r2911: ArcTimerInfo() = default; /mnt/host/source/src/platform2/power_manager/powerd/system/arc_timer_manager.cc:90:19: note: default constructor of 'ArcTimerInfo' is implicitly deleted because field 'clock_id' of const-qualified type 'const clockid_t' (aka 'const int') would not be initialized power_manager-0.0.2-r2911: const clockid_t clock_id; BUG= chromium:910677 TEST=power_manager builds with llvm-next. Change-Id: I978dcb99fa022b83f1665236549f7e9c9251bd82 Reviewed-on: https://chromium-review.googlesource.com/1357316 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/e41b7bad1c3867b5bdf10b8d94cd5fec3d99c79b/power_manager/powerd/system/arc_timer_manager.cc
,
Dec 3
drivefs cl submitted to Google upstream in cl/223792785. sammc@ please reassign to me once the CL make it to Chrome OS.
,
Dec 4
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/142bfccb462f28333dd86be0c579d26584ef66ca commit 142bfccb462f28333dd86be0c579d26584ef66ca Author: Sam McNally <sammc@google.com> Date: Tue Dec 04 08:11:38 2018
,
Dec 4
,
Dec 5
Thanks, looks like the build issue are fixed. https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8928046476250354096 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by cmt...@chromium.org
, Nov 30