New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 910675 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Download Home] Read out number of files when a chip is selected

Project Member Reported by shaktisahu@chromium.org, Nov 30

Issue description

For accessibility, we should read out the number of files when a chip is selected. The exact string will be given by the UX.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99f96e85b1ab4b2896ee207eff264c069fb174d7

commit 99f96e85b1ab4b2896ee207eff264c069fb174d7
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Thu Jan 10 01:46:18 2019

Download Home : Accessibility for chip row announcing number of items

With this CL, tapping on chips in accessibility mode would announce the
number of files being shown for the chip. For All/Other chips, it
would use a generic term 'files' instead.

Bug:  910675 
Change-Id: I27d3b2bdf0321f8e2b5fe9990bdc159b94504c03
Reviewed-on: https://chromium-review.googlesource.com/c/1399540
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621413}
[modify] https://crrev.com/99f96e85b1ab4b2896ee207eff264c069fb174d7/chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/FilterChipsProvider.java
[modify] https://crrev.com/99f96e85b1ab4b2896ee207eff264c069fb174d7/chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/FilterCoordinator.java
[modify] https://crrev.com/99f96e85b1ab4b2896ee207eff264c069fb174d7/chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/chips/Chip.java
[modify] https://crrev.com/99f96e85b1ab4b2896ee207eff264c069fb174d7/chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/chips/ChipsViewHolder.java
[modify] https://crrev.com/99f96e85b1ab4b2896ee207eff264c069fb174d7/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/UiUtils.java
[modify] https://crrev.com/99f96e85b1ab4b2896ee207eff264c069fb174d7/chrome/android/java/strings/android_chrome_strings.grd

Cc: krav...@chromium.org
Status: Fixed (was: Available)
kravula@ - Can you verify this bug? Thanks!
Labels: Merge-Request-72
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 10

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 18 days from stable.
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-72 Merge-Rejected-72
Rejecting merge to M72 as this includes string chang.
M72 feature/string freeze was on 11/09/18 & Branched on 11/29/18 so it is too late to accept string change this late in release cycle.

Comment 6 by kravula@google.com, Jan 17 (5 days ago)

Verified on M73-73.0.3674.0/Nokia 7 Plus/9.0

When tap on All option -> reading as Selected 3 files(since they are files downloaded) in list 3 items, double tap to activate.

Not reading the "ALL" text.


Screenshot_20190117-151413.png
213 KB View Download

Comment 7 by shaktisahu@chromium.org, Jan 17 (5 days ago)

Yes, that is correct. We want to use "file" for ALL and Other chips. 
For audio, we say "audio files", for images, "images" and for videos, it is "videos"

Sign in to add a comment