[Fuchsia] Migrate to new "core" SDK |
||||||
Issue descriptionWe'd like to start using the Fuchsia SDK images from gs://fuchsia/sdk/core in place of our existing ones, in Chromium. This will require updates to our auto-roller and update_sdk.py script; we could update the script itself to be capable of being run to provide a "latest" SDK hash to use, for example, update the roller to use that, then update the script to switch where we pull from.
,
Nov 30
,
Dec 7
Any updates? We'd like to start removing the old paths as soon as possible. Thanks!
,
Dec 11
,
Dec 11
,
Dec 11
awolter@ has posted auto-roller update at https://skia-review.googlesource.com/c/buildbot/+/176384 I'm working on the Chromium-side changes now, which require some tweaks to our BUILD generator.
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ed2b6cabb34340a5093b894250bd5c8292ed625 commit 0ed2b6cabb34340a5093b894250bd5c8292ed625 Author: Wez <wez@chromium.org> Date: Wed Dec 12 01:42:55 2018 [Fuchsia] Generate more complete GN target names for FIDL packages. FIDL package names consist of multiple dot-delimited segments, to allow scoping of packages to avoid clashes. Our GN generator script was using only the final segment of each package's name, resulting in clashes, e.g. between fuchsia.auth and fuchsia.modular.auth, if both were present in the SDK. We continue to generate targets under the //third_party/fuchsia-sdk/sdk namespace, but use the full name rather than only the final segment, e.g. custom.modular.auth would become custom_modular_auth. We also special-case the top-level "fuchsia" namespace to be ignored, e.g. fuchsia.modular_auth becomes just modular_auth. Bug: 910670 Change-Id: I675d894c72b5d43b6d8b20fb026075573a5a3380 Reviewed-on: https://chromium-review.googlesource.com/c/1372892 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#615763} [modify] https://crrev.com/0ed2b6cabb34340a5093b894250bd5c8292ed625/third_party/fuchsia-sdk/gen_build_defs.py [modify] https://crrev.com/0ed2b6cabb34340a5093b894250bd5c8292ed625/webrunner/BUILD.gn [modify] https://crrev.com/0ed2b6cabb34340a5093b894250bd5c8292ed625/webrunner/net_http/BUILD.gn
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/112340ed3f51801317db62e7d9e51206dcddd01f commit 112340ed3f51801317db62e7d9e51206dcddd01f Author: Alice Boxhall <aboxhall@chromium.org> Date: Wed Dec 12 02:13:39 2018 Revert "[Fuchsia] Generate more complete GN target names for FIDL packages." This reverts commit 0ed2b6cabb34340a5093b894250bd5c8292ed625. Reason for revert: Seems to be causing build breakages on Fuchsia bots https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20ARM64/47071 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64/25530 Original change's description: > [Fuchsia] Generate more complete GN target names for FIDL packages. > > FIDL package names consist of multiple dot-delimited segments, to allow > scoping of packages to avoid clashes. Our GN generator script was using > only the final segment of each package's name, resulting in clashes, > e.g. between fuchsia.auth and fuchsia.modular.auth, if both were > present in the SDK. > > We continue to generate targets under the //third_party/fuchsia-sdk/sdk > namespace, but use the full name rather than only the final segment, > e.g. custom.modular.auth would become custom_modular_auth. > > We also special-case the top-level "fuchsia" namespace to be ignored, > e.g. fuchsia.modular_auth becomes just modular_auth. > > Bug: 910670 > Change-Id: I675d894c72b5d43b6d8b20fb026075573a5a3380 > Reviewed-on: https://chromium-review.googlesource.com/c/1372892 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615763} TBR=wez@chromium.org,kmarshall@chromium.org Change-Id: Ibc33ed422c1365b019bf53ca8e4fdb26ee781038 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910670 Reviewed-on: https://chromium-review.googlesource.com/c/1372111 Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#615784} [modify] https://crrev.com/112340ed3f51801317db62e7d9e51206dcddd01f/third_party/fuchsia-sdk/gen_build_defs.py [modify] https://crrev.com/112340ed3f51801317db62e7d9e51206dcddd01f/webrunner/BUILD.gn [modify] https://crrev.com/112340ed3f51801317db62e7d9e51206dcddd01f/webrunner/net_http/BUILD.gn
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a4d2b2ccc6ee5bac0ef1ff2e765749ea4199b2f commit 3a4d2b2ccc6ee5bac0ef1ff2e765749ea4199b2f Author: Wez <wez@chromium.org> Date: Wed Dec 12 17:55:42 2018 Reland "[Fuchsia] Generate more complete GN target names for FIDL packages." This is a reland of 0ed2b6cabb34340a5093b894250bd5c8292ed625 Original change's description: > [Fuchsia] Generate more complete GN target names for FIDL packages. > > FIDL package names consist of multiple dot-delimited segments, to allow > scoping of packages to avoid clashes. Our GN generator script was using > only the final segment of each package's name, resulting in clashes, > e.g. between fuchsia.auth and fuchsia.modular.auth, if both were > present in the SDK. > > We continue to generate targets under the //third_party/fuchsia-sdk/sdk > namespace, but use the full name rather than only the final segment, > e.g. custom.modular.auth would become custom_modular_auth. > > We also special-case the top-level "fuchsia" namespace to be ignored, > e.g. fuchsia.modular_auth becomes just modular_auth. > > Bug: 910670 > Change-Id: I675d894c72b5d43b6d8b20fb026075573a5a3380 > Reviewed-on: https://chromium-review.googlesource.com/c/1372892 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615763} Bug: 910670 Change-Id: I2b7c5d766f5ee7cfe2d31b10f8410075efd52288 Reviewed-on: https://chromium-review.googlesource.com/c/1373276 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#615950} [modify] https://crrev.com/3a4d2b2ccc6ee5bac0ef1ff2e765749ea4199b2f/content/shell/BUILD.gn [modify] https://crrev.com/3a4d2b2ccc6ee5bac0ef1ff2e765749ea4199b2f/net/BUILD.gn [modify] https://crrev.com/3a4d2b2ccc6ee5bac0ef1ff2e765749ea4199b2f/services/service_manager/sandbox/BUILD.gn [modify] https://crrev.com/3a4d2b2ccc6ee5bac0ef1ff2e765749ea4199b2f/third_party/fuchsia-sdk/gen_build_defs.py [modify] https://crrev.com/3a4d2b2ccc6ee5bac0ef1ff2e765749ea4199b2f/ui/base/ime/BUILD.gn [modify] https://crrev.com/3a4d2b2ccc6ee5bac0ef1ff2e765749ea4199b2f/ui/events/BUILD.gn [modify] https://crrev.com/3a4d2b2ccc6ee5bac0ef1ff2e765749ea4199b2f/ui/ozone/demo/BUILD.gn [modify] https://crrev.com/3a4d2b2ccc6ee5bac0ef1ff2e765749ea4199b2f/ui/ozone/platform/scenic/BUILD.gn [modify] https://crrev.com/3a4d2b2ccc6ee5bac0ef1ff2e765749ea4199b2f/ui/platform_window/BUILD.gn [modify] https://crrev.com/3a4d2b2ccc6ee5bac0ef1ff2e765749ea4199b2f/webrunner/BUILD.gn [modify] https://crrev.com/3a4d2b2ccc6ee5bac0ef1ff2e765749ea4199b2f/webrunner/net_http/BUILD.gn
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c098436e1a3ddf3dea8fdc4c6fd8ad940993878 commit 3c098436e1a3ddf3dea8fdc4c6fd8ad940993878 Author: Wez <wez@chromium.org> Date: Wed Dec 12 18:06:44 2018 [Fuchsia] Switch to use 'core' SDK in Chromium. Bug: 910670 Change-Id: Ieac8ffe1ebaf49c4faad10fc83791d384231ac32 Reviewed-on: https://chromium-review.googlesource.com/c/1372910 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#615957} [modify] https://crrev.com/3c098436e1a3ddf3dea8fdc4c6fd8ad940993878/build/fuchsia/linux.sdk.sha1 [modify] https://crrev.com/3c098436e1a3ddf3dea8fdc4c6fd8ad940993878/build/fuchsia/mac.sdk.sha1 [modify] https://crrev.com/3c098436e1a3ddf3dea8fdc4c6fd8ad940993878/build/fuchsia/update_sdk.py
,
Dec 12
Auto-roll is in-progress and seems to have build, OK, and test-suites are running, so closing this out. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by w...@chromium.org
, Nov 30