New issue
Advanced search Search tips

Issue 910667 link

Starred by 1 user
Status: Fixed
Owner:
zhuoyu.q...@samsung.com
Closed: Jan 14
Cc:
tbansal@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename chrome/browser/net/spdyproxy to chrome/browser/net/data_reduction_proxy

Project Member Reported by eroman@chromium.org, Nov 30 
We use an inconsistent set of names for this feature:

  * Data Reduction Proxy (as in components/data_reduction_proxy)
  * Chrome Proxy (as in tools/chrome_proxy)
chrome/browser/data_saver)
  * Custom Proxy (as in Network Service's CustomProxyConfig)
  * Spdy Proxy (as in chrome/browser/net/spdyproxy)
  * Data saver (or maybe that is a distinct component?)

This proposal is to remove the nomenclature spdyproxy, since that can have different meaning in //net.

Comment 1 by bengr@chromium.org, Dec 5

Cc: tbansal@chromium.org
Labels: Hotlist-GoodFirstBug
Status: Available (was: Untriaged)

Comment 2 by zhuoyu.q...@samsung.com, Dec 7

Owner: zhuoyu.q...@samsung.com
Status: Assigned (was: Available)
I'll take this.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148

commit cb1976385b7bdc4d1421070f5afdeeeaf3ff5148
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Thu Dec 13 02:18:30 2018

Rename chrome/browser/net/spdyproxy to chrome/browser/data_reduction_proxy

This proposal is to remove the nomenclature spdyproxy, since that can have
different meaning in //net.

Bug:  910667 
Change-Id: I05ecfe6b09dd102ac7b42a1291b311037d1386c5
Reviewed-on: https://chromium-review.googlesource.com/c/1367083
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616165}
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/BUILD.gn
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_factory.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/chrome_content_browser_client.cc
[rename] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/data_reduction_proxy/OWNERS
[rename] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/data_reduction_proxy/data_reduction_promo_infobar_delegate_android.cc
[rename] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/data_reduction_proxy/data_reduction_promo_infobar_delegate_android.h
[rename] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/data_reduction_proxy/data_reduction_proxy_browsertest.cc
[rename] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/data_reduction_proxy/data_reduction_proxy_chrome_io_data.cc
[rename] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/data_reduction_proxy/data_reduction_proxy_chrome_io_data.h
[rename] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/data_reduction_proxy/data_reduction_proxy_chrome_settings.cc
[rename] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/data_reduction_proxy/data_reduction_proxy_chrome_settings.h
[rename] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/data_reduction_proxy/data_reduction_proxy_chrome_settings_factory.cc
[rename] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/data_reduction_proxy/data_reduction_proxy_chrome_settings_factory.h
[rename] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/data_reduction_proxy/data_reduction_proxy_chrome_settings_unittest.cc
[rename] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/data_reduction_proxy/data_reduction_proxy_settings_android.cc
[rename] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/data_reduction_proxy/data_reduction_proxy_settings_android.h
[rename] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/data_reduction_proxy/data_reduction_proxy_settings_unittest_android.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/data_saver/data_saver_browsertest.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/net/profile_network_context_service.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_base.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer_browsertest.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/page_load_metrics/observers/previews_ukm_observer.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/previews/previews_infobar_delegate.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/previews/previews_lite_page_browsertest.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/previews/previews_lite_page_decider.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/previews/previews_lite_page_navigation_throttle.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/previews/previews_ui_tab_helper.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/previews/previews_ui_tab_helper_unittest.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/ui/android/infobars/data_reduction_promo_infobar.cc
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/browser/ui/android/infobars/data_reduction_promo_infobar.h
[modify] https://crrev.com/cb1976385b7bdc4d1421070f5afdeeeaf3ff5148/chrome/test/BUILD.gn

Comment 5 by zhuoyu.q...@samsung.com, Jan 14

Status: Fixed (was: Assigned)
►

Sign in to add a comment