New issue
Advanced search Search tips

Issue 910641 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Enable mosys C unittests

Project Member Reported by gmeinke@chromium.org, Nov 30

Issue description

Enable and provide good amount of unittest coverage
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3dea426b304c45551d9543a38f5837ec09ccb496

commit 3dea426b304c45551d9543a38f5837ec09ccb496
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Sun Dec 02 05:19:15 2018

mosys: enable meson testing

This will try to run any meson tests defined for mosys, which is
currently the empty set. The three unit tests in the current repo
are old and do not compile.

Next steps will be to convert these tests from cmockery to cmocka
and then enable them.

BUG=chromium:910641
TEST=Run local builds and tests for X86 and ARM

Change-Id: I160d4f06c2e82a2d0dae9c36937d131dfc25d2e0
Reviewed-on: https://chromium-review.googlesource.com/1357121
Commit-Ready: Gregory Meinke <gmeinke@chromium.org>
Tested-by: Gregory Meinke <gmeinke@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/3dea426b304c45551d9543a38f5837ec09ccb496/sys-apps/mosys/mosys-9999.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a019eb92c48d6cb29277a2644f8089a8912d8c5f

commit a019eb92c48d6cb29277a2644f8089a8912d8c5f
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Wed Dec 05 01:40:17 2018

mosys: add dependency on cmocka

Moving the mosys unittests to cmocka from unmaintained cmockery.

BUG=chromium:910641
TEST=local builds and meson unittests

Change-Id: Iba12d9e688475a0e82667432be1f12a9d75e06ff
Reviewed-on: https://chromium-review.googlesource.com/1357823
Commit-Ready: Gregory Meinke <gmeinke@chromium.org>
Tested-by: Gregory Meinke <gmeinke@chromium.org>
Reviewed-by: Evan Hernandez <evanhernandez@chromium.org>

[modify] https://crrev.com/a019eb92c48d6cb29277a2644f8089a8912d8c5f/sys-apps/mosys/mosys-9999.ebuild

Comment 4 Deleted

Sign in to add a comment