New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 910596 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[autofill] Priority pref name mismatch for kAutofillProfileValidity

Project Member Reported by rogerm@chromium.org, Nov 30

Issue description

The value of the autofill::prefs::kAutofillProfileValidity pref
name does not match the actual value being used to populate the
priority pref from the server

Chrome: autofill.profile_validity
Server: autofill_profile_validity

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e01904144049103cbf0381fa29e0ff836549f7d0

commit e01904144049103cbf0381fa29e0ff836549f7d0
Author: Roger McFarlane <rogerm@chromium.org>
Date: Fri Nov 30 21:36:28 2018

[autofill] Fix autofill::prefs::kAutofillProfileValidity

The value of the autofill::prefs::kAutofillProfileValidity pref
name does not match the actual value being used to populate the
priority pref from the server.

Thie CL changes this constant from autofill.profile_validity to
autofill_profile_validity to match what's actually being synced.

Change-Id: I151874de8dde861dff280e1fc0e53e2ee1b60d84
Bug:  910596 
Reviewed-on: https://chromium-review.googlesource.com/c/1356863
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612793}
[modify] https://crrev.com/e01904144049103cbf0381fa29e0ff836549f7d0/components/autofill/core/common/autofill_prefs.cc

Labels: -M-71 M-72 Merge-Request-72
Labels: -Merge-Request-72 Merge-Approved-72
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 12

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93e45e47ab458e51ee4b3c272b2eb31a05b183a5

commit 93e45e47ab458e51ee4b3c272b2eb31a05b183a5
Author: Roger McFarlane <rogerm@chromium.org>
Date: Wed Dec 12 20:58:42 2018

[autofill] Fix autofill::prefs::kAutofillProfileValidity

The value of the autofill::prefs::kAutofillProfileValidity pref
name does not match the actual value being used to populate the
priority pref from the server.

Thie CL changes this constant from autofill.profile_validity to
autofill_profile_validity to match what's actually being synced.

Change-Id: I151874de8dde861dff280e1fc0e53e2ee1b60d84
Bug:  910596 
Reviewed-on: https://chromium-review.googlesource.com/c/1356863
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612793}(cherry picked from commit e01904144049103cbf0381fa29e0ff836549f7d0)
Reviewed-on: https://chromium-review.googlesource.com/c/1374576
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#307}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/93e45e47ab458e51ee4b3c272b2eb31a05b183a5/components/autofill/core/common/autofill_prefs.cc

Status: Fixed (was: Untriaged)
Status: Verified (was: Fixed)
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/93e45e47ab458e51ee4b3c272b2eb31a05b183a5

Commit: 93e45e47ab458e51ee4b3c272b2eb31a05b183a5
Author: rogerm@chromium.org
Commiter: rogerm@chromium.org
Date: 2018-12-12 20:58:42 +0000 UTC

[autofill] Fix autofill::prefs::kAutofillProfileValidity

The value of the autofill::prefs::kAutofillProfileValidity pref
name does not match the actual value being used to populate the
priority pref from the server.

Thie CL changes this constant from autofill.profile_validity to
autofill_profile_validity to match what's actually being synced.

Change-Id: I151874de8dde861dff280e1fc0e53e2ee1b60d84
Bug:  910596 
Reviewed-on: https://chromium-review.googlesource.com/c/1356863
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612793}(cherry picked from commit e01904144049103cbf0381fa29e0ff836549f7d0)
Reviewed-on: https://chromium-review.googlesource.com/c/1374576
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#307}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment