Report serial number on Windows |
|||||||||||
Issue descriptionThis will allow us to transition the device id to the serial number.
,
Dec 4
,
Dec 4
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36d28a9b535e70c5b5389f852ee36152051e3d90 commit 36d28a9b535e70c5b5389f852ee36152051e3d90 Author: Owen Min <zmin@chromium.org> Date: Wed Dec 05 16:41:14 2018 Resolve cloud reporting hanging issue. Reporting is hanging while retrieving serial number as the callback never return. Allow nested task so that the sub-task can be finished. Bug: 910594 Change-Id: Iba03c7e7f50716a2e38352ba970c69e88ed921c9 Reviewed-on: https://chromium-review.googlesource.com/c/1361837 Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#613991} [modify] https://crrev.com/36d28a9b535e70c5b5389f852ee36152051e3d90/chrome/browser/policy/browser_dm_token_storage.cc
,
Dec 7
The two CLs above needs to be merged into M72 as they are required by TT of cloud management.
,
Dec 8
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f49d5629e19eb022a4f9e4d488a5937e9837112b commit f49d5629e19eb022a4f9e4d488a5937e9837112b Author: Georges Khalil <georgesak@chromium.org> Date: Mon Dec 10 15:47:45 2018 Merge "Add serial number to cloud reports." Merge it into M72. This CL adds the serial number to cloud reporting, as a step to transition to using that as the client ID. Bug: 910594 Change-Id: I7b336da99f2f7304b3e03b7a3a25aa07715749d2 Reviewed-on: https://chromium-review.googlesource.com/c/1354342 Commit-Queue: Georges Khalil <georgesak@chromium.org> Reviewed-by: Owen Min <zmin@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612696}(cherry picked from commit d22640a59e231c4cc2ac89d13fb035c71e0d3b6f) Reviewed-on: https://chromium-review.googlesource.com/c/1369634 Cr-Commit-Position: refs/branch-heads/3626@{#198} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/f49d5629e19eb022a4f9e4d488a5937e9837112b/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper.cc [modify] https://crrev.com/f49d5629e19eb022a4f9e4d488a5937e9837112b/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper_unittest.cc [modify] https://crrev.com/f49d5629e19eb022a4f9e4d488a5937e9837112b/chrome/browser/policy/browser_dm_token_storage.cc [modify] https://crrev.com/f49d5629e19eb022a4f9e4d488a5937e9837112b/chrome/browser/policy/browser_dm_token_storage.h [modify] https://crrev.com/f49d5629e19eb022a4f9e4d488a5937e9837112b/chrome/browser/policy/browser_dm_token_storage_unittest.cc [modify] https://crrev.com/f49d5629e19eb022a4f9e4d488a5937e9837112b/components/policy/proto/device_management_backend.proto
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cb7bce511460d9e0734b3a00f65a5dec00ea911 commit 7cb7bce511460d9e0734b3a00f65a5dec00ea911 Author: Owen Min <zmin@chromium.org> Date: Mon Dec 10 15:48:15 2018 Merge "Resolve cloud reporting hanging issue." Merge it into M72 Reporting is hanging while retrieving serial number as the callback never return. Allow nested task so that the sub-task can be finished. Bug: 910594 Change-Id: Iba03c7e7f50716a2e38352ba970c69e88ed921c9 Reviewed-on: https://chromium-review.googlesource.com/c/1361837 Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613991}(cherry picked from commit 36d28a9b535e70c5b5389f852ee36152051e3d90) Reviewed-on: https://chromium-review.googlesource.com/c/1369635 Reviewed-by: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#199} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/7cb7bce511460d9e0734b3a00f65a5dec00ea911/chrome/browser/policy/browser_dm_token_storage.cc
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2468bf0f7ef1e325a74f0efc7ff649bc275f599b commit 2468bf0f7ef1e325a74f0efc7ff649bc275f599b Author: Owen Min <zmin@chromium.org> Date: Wed Dec 12 15:30:27 2018 Move serial number in cloud reporting Serial number should be put at the top level of report as it doesn't belong to any Browser or Profile instance. Bug: 910594 Change-Id: I1a70c322814c3b7f03ac3d8bf23ea64c38e31d22 Reviewed-on: https://chromium-review.googlesource.com/c/1372713 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#615896} [modify] https://crrev.com/2468bf0f7ef1e325a74f0efc7ff649bc275f599b/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper.cc [modify] https://crrev.com/2468bf0f7ef1e325a74f0efc7ff649bc275f599b/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper_unittest.cc [modify] https://crrev.com/2468bf0f7ef1e325a74f0efc7ff649bc275f599b/components/policy/proto/device_management_backend.proto
,
Dec 12
The CL in #9 is a small fix of the issue, we would like to merge this into M72 so that it can be synced with the proto on the server side.
,
Dec 12
Is this only for enterprise? Are there any other implications towards clientIDs (used in uma/crash)? Has this been vetted with privacy as well?
,
Dec 12
Yes, it is. And it's controlled by policy (CloudReportingEnabled). No, there is no other usage in Chrome. We currently uploads this data just as additional device information that admin can see on the Admin Console. No, the project is in TT so we haven't go through privacy review yet. (We did talked with privacy team about the overview of the project). Also 1) This data has already been uploaded to Admin Console by other project via Chrome extension (SecureConnect) 2) The change only affects our TT users.
,
Dec 12
Thanks for more feedback. Approving for M72.
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94cc5add95f5869df3962f573f54f843761d7ad6 commit 94cc5add95f5869df3962f573f54f843761d7ad6 Author: Owen Min <zmin@chromium.org> Date: Wed Dec 12 23:01:13 2018 Merge "Move serial number in cloud reporting" Merge into M72 Serial number should be put at the top level of report as it doesn't belong to any Browser or Profile instance. Bug: 910594 Change-Id: I1a70c322814c3b7f03ac3d8bf23ea64c38e31d22 Reviewed-on: https://chromium-review.googlesource.com/c/1372713 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615896}(cherry picked from commit 2468bf0f7ef1e325a74f0efc7ff649bc275f599b) Reviewed-on: https://chromium-review.googlesource.com/c/1374775 Reviewed-by: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#313} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/94cc5add95f5869df3962f573f54f843761d7ad6/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper.cc [modify] https://crrev.com/94cc5add95f5869df3962f573f54f843761d7ad6/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper_unittest.cc [modify] https://crrev.com/94cc5add95f5869df3962f573f54f843761d7ad6/components/policy/proto/device_management_backend.proto
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cb7bce511460d9e0734b3a00f65a5dec00ea911 Commit: 7cb7bce511460d9e0734b3a00f65a5dec00ea911 Author: zmin@chromium.org Commiter: zmin@chromium.org Date: 2018-12-10 15:48:15 +0000 UTC Merge "Resolve cloud reporting hanging issue." Merge it into M72 Reporting is hanging while retrieving serial number as the callback never return. Allow nested task so that the sub-task can be finished. Bug: 910594 Change-Id: Iba03c7e7f50716a2e38352ba970c69e88ed921c9 Reviewed-on: https://chromium-review.googlesource.com/c/1361837 Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613991}(cherry picked from commit 36d28a9b535e70c5b5389f852ee36152051e3d90) Reviewed-on: https://chromium-review.googlesource.com/c/1369635 Reviewed-by: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#199} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94cc5add95f5869df3962f573f54f843761d7ad6 Commit: 94cc5add95f5869df3962f573f54f843761d7ad6 Author: zmin@chromium.org Commiter: zmin@chromium.org Date: 2018-12-12 23:01:13 +0000 UTC Merge "Move serial number in cloud reporting" Merge into M72 Serial number should be put at the top level of report as it doesn't belong to any Browser or Profile instance. Bug: 910594 Change-Id: I1a70c322814c3b7f03ac3d8bf23ea64c38e31d22 Reviewed-on: https://chromium-review.googlesource.com/c/1372713 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615896}(cherry picked from commit 2468bf0f7ef1e325a74f0efc7ff649bc275f599b) Reviewed-on: https://chromium-review.googlesource.com/c/1374775 Reviewed-by: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#313} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f49d5629e19eb022a4f9e4d488a5937e9837112b Commit: f49d5629e19eb022a4f9e4d488a5937e9837112b Author: georgesak@chromium.org Commiter: zmin@chromium.org Date: 2018-12-10 15:47:45 +0000 UTC Merge "Add serial number to cloud reports." Merge it into M72. This CL adds the serial number to cloud reporting, as a step to transition to using that as the client ID. Bug: 910594 Change-Id: I7b336da99f2f7304b3e03b7a3a25aa07715749d2 Reviewed-on: https://chromium-review.googlesource.com/c/1354342 Commit-Queue: Georges Khalil <georgesak@chromium.org> Reviewed-by: Owen Min <zmin@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612696}(cherry picked from commit d22640a59e231c4cc2ac89d13fb035c71e0d3b6f) Reviewed-on: https://chromium-review.googlesource.com/c/1369634 Cr-Commit-Position: refs/branch-heads/3626@{#198} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 16
(6 days ago)
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by bugdroid1@chromium.org
, Nov 30