Remove linked_ptr from LayerAnimator |
||
Issue descriptionLayerAnimator uses linked_ptr in AnimationQueue. This doesn't seem to be an ownership scenario, since a48f30dae3eb9b572e3db2d11b5591053988b68f added lots of weak pointers to make sure that running animation pointers don't go stale, which couldn't happen with strong ownership. linked_ptr is obsolete. If animations should be shared, move to shared_ptr. If they should be owned, fix ownership, move to unique_ptr, and remove all the weak pointer stuff. -> vollick who added that
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37e51bd14ffaeb35fb0e6acea0db8321bf10c5f3 commit 37e51bd14ffaeb35fb0e6acea0db8321bf10c5f3 Author: Ian Vollick <vollick@chromium.org> Date: Tue Dec 18 14:32:09 2018 Do not use linked_ptr in LayerAnimator With this CL, the LayerAnimator no longer uses linked_ptr, however it does not clean up the use of weak_ptr, so there is still work to be done. Bug: 910591 Change-Id: I6d4bb0e995278638e569af27f334d8a19262c17e Reviewed-on: https://chromium-review.googlesource.com/c/1379400 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#617481} [modify] https://crrev.com/37e51bd14ffaeb35fb0e6acea0db8321bf10c5f3/ui/compositor/layer_animator.cc [modify] https://crrev.com/37e51bd14ffaeb35fb0e6acea0db8321bf10c5f3/ui/compositor/layer_animator.h
,
Dec 18
The linked_ptr stuff has been fixed, so I'm going to mark this as fixed. I've logged crbug.com/916124 to track the other ownership issues in LayerAnimation.
,
Dec 18
Thank you! |
||
►
Sign in to add a comment |
||
Comment 1 by vollick@google.com
, Dec 12