New issue
Advanced search Search tips

Issue 910590 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocking:
issue 907767



Sign in to add a comment

media/gpu: Create DBABuf-backed VideoFrame in VEA with v4l2 ImageProcessor,

Project Member Reported by deanliao@google.com, Nov 30

Issue description

To make ImageProcessor operate on import mode, its caller, VEA (Video Encoder Accelerator), should create VideoFrame for ImageProcessor use as output. For V4L2 ImageProcessor, its only accepts DMAbuf-backed VideoFrame as output. So VEA needs to allocate DMAbuf-backed VideoFrame. Ozone platform has ability to create DMAbuf-backed VideoFrame.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bab718a9743aa3e334b696c4d617157acb446d21

commit bab718a9743aa3e334b696c4d617157acb446d21
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Thu Dec 06 02:16:01 2018

media/gpu/PlatformVideoFrame: Add function to create DmaBuf-backed VideoFrame using NativePixmap

VideoFrame only has the function to create DmaBuf-backed VideoFrame with already
created DmaBuf fds, WrapExternalDmabufs(). This adds a function to create Dmabuf-backed
VideoFrame usintg NativePixmap, CreatePlatformVideoFrame. The function is currently
supported on only Ozone platform.

Bug: 910590
Test: VDA and VEA unittest on exynos
Change-Id: I726369deecbdf9f1ae70829b36e59c72034feeae
Reviewed-on: https://chromium-review.googlesource.com/c/1358198
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614233}
[modify] https://crrev.com/bab718a9743aa3e334b696c4d617157acb446d21/media/base/video_frame_layout.cc
[modify] https://crrev.com/bab718a9743aa3e334b696c4d617157acb446d21/media/base/video_frame_layout.h
[modify] https://crrev.com/bab718a9743aa3e334b696c4d617157acb446d21/media/base/video_frame_layout_unittest.cc
[modify] https://crrev.com/bab718a9743aa3e334b696c4d617157acb446d21/media/gpu/BUILD.gn
[add] https://crrev.com/bab718a9743aa3e334b696c4d617157acb446d21/media/gpu/platform_video_frame.cc
[add] https://crrev.com/bab718a9743aa3e334b696c4d617157acb446d21/media/gpu/platform_video_frame.h
[modify] https://crrev.com/bab718a9743aa3e334b696c4d617157acb446d21/media/gpu/test/texture_ref.cc
[modify] https://crrev.com/bab718a9743aa3e334b696c4d617157acb446d21/media/gpu/test/texture_ref.h
[modify] https://crrev.com/bab718a9743aa3e334b696c4d617157acb446d21/media/gpu/test/video_encode_accelerator_unittest_helpers.cc
[modify] https://crrev.com/bab718a9743aa3e334b696c4d617157acb446d21/media/gpu/v4l2/v4l2_device_unittest.cc
[modify] https://crrev.com/bab718a9743aa3e334b696c4d617157acb446d21/media/gpu/video_decode_accelerator_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d39704b06e37a38fe930cf149e1c712a49a9321

commit 5d39704b06e37a38fe930cf149e1c712a49a9321
Author: Daniel Bratell <bratell@opera.com>
Date: Wed Jan 09 09:33:53 2019

Remove the ::media::gpu namespace which conflicted with ::gpu

We should not have sub namespace with the same name as top level
namespaces since that causes name lookup conflicts. ::media::gpu
in particular was only used by a single function, and I'm sure
it will be fine in ::media instead, saving us from having to
write ::gpu everywhere.

This broke the build in certain jumbo build configurations.

Bug: 910590

Change-Id: Ic735dedfe39485ec5f2bd0d0adcce22fa12ec951
Reviewed-on: https://chromium-review.googlesource.com/c/1400823
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#621088}
[modify] https://crrev.com/5d39704b06e37a38fe930cf149e1c712a49a9321/media/gpu/platform_video_frame.cc
[modify] https://crrev.com/5d39704b06e37a38fe930cf149e1c712a49a9321/media/gpu/platform_video_frame.h
[modify] https://crrev.com/5d39704b06e37a38fe930cf149e1c712a49a9321/media/gpu/test/texture_ref.cc

Sign in to add a comment