New issue
Advanced search Search tips

Issue 910563 link

Starred by 2 users

Issue metadata

Status: Assigned
Merged: issue 906587
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

SitePerProcessBrowserTest.ChildFrameCrashMetrics tests are flaky on Android

Project Member Reported by alexilin@chromium.org, Nov 30

Issue description

The test crashes from time to time on Android testers. It recently caused a build failure on Marshmallow 64 bit Tester: 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Marshmallow%2064%20bit%20Tester/25130

Flakiness dashboard: 
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=SitePerProcessBrowserTest.ChildFrameCrashMetrics_KilledWhileVisible

Failure log:
[ RUN      ] SitePerProcessBrowserTest.ChildFrameCrashMetrics_KilledWhileVisible
[WARNING:dns_config_service_posix.cc(334)] Failed to read DnsConfig.
[WARNING:child_process_launcher_helper_posix.cc(124)] Ignoring invalid file assets/snapshot_blob_32.bin
[WARNING:simple_synchronous_entry.cc(1251)] Could not open platform files for entry.
[WARNING:child_process_launcher_helper_posix.cc(124)] Ignoring invalid file assets/snapshot_blob_32.bin
[ERROR:shell_android.cc(79)] Not implemented reached in void content::Shell::PlatformSetTitle(const base::string16 &): Cross-site iframe factory
[WARNING:child_process_launcher_helper_posix.cc(124)] Ignoring invalid file assets/snapshot_blob_32.bin
[WARNING:child_process_launcher_helper_posix.cc(124)] Ignoring invalid file assets/snapshot_blob_32.bin
[FATAL:begin_frame_source.cc(63)] Check failed: args.sequence_number > last_begin_frame_args_.sequence_number || args.source_id != last_begin_frame_args_.source_id. current {"type":"BeginFrameArgs","subtype":"MISSED","source_id":0,"sequence_number":80,"frame_time_us":1671727644.0,"deadline_us":1671748936.0,"interval_us":16666.0,"created_from":"OnVSync@../../ui/android/window_android.cc:132","on_critical_path":true,"animate_only":false}, last {"type":"BeginFrameArgs","subtype":"MISSED","source_id":0,"sequence_number":80,"frame_time_us":1671727644.0,"deadline_us":1671748217.0,"interval_us":16666.0,"created_from":"OnVSync@../../ui/android/window_android.cc:132","on_critical_path":true,"animate_only":false}

[ERROR:test_suite.cc(325)] Currently running: SitePerProcessBrowserTest.ChildFrameCrashMetrics_KilledWhileVisible
Reading Android symbols from: /b/swarming/w/ir
Searching for Chrome symbols from within: /b/swarming/w/ir/out/Debug/lib.unstripped:/b/swarming/w/ir/out/Debug
Searching for native crashes in: /b/swarming/w/itRTLY_J/tmpU2pnmh
Unknown Android release, consider passing --packed-lib.
Searching for Chrome symbols from within: /b/swarming/w/ir/out/Debug/lib.unstripped:/b/swarming/w/ir/out/Debug

[...] truncated because the comment would be too long, full version in the attached file
 
crash.log
80.2 KB View Download
Cc: eseckler@chromium.org
Components: Tests>Flaky
Labels: sheriff-android
Owner: lukasza@chromium.org
Status: Assigned (was: Untriaged)
+lukasza@ as an author of the test

+eseckler@, a DCHECK you've added is hit here, could you take a look?
Cc: lukasza@chromium.org sunn...@chromium.org sadrul@chromium.org
Owner: sadrul@chromium.org
The DCHECK verifies that BeginFrames received by BeginFrameObservers are sequentially ordered. It seems that WindowAndroid::OnGpuNoLongerBusy [1] issues an old BeginFrame a second time which violates that constraint.

+sunnyps and +sadrul

Sadrul, I think this may be related to your change [2].

[1] https://cs.chromium.org/chromium/src/ui/android/window_android.cc?type=cs&q=OnGpuNoLongerBusy&sq=package:chromium&g=0&l=123
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1299206
Mergedinto: 906587
Status: Duplicate (was: Assigned)
Status: Assigned (was: Duplicate)
Sorry, wrong merge, please ignore.
Issue 911618 has been merged into this issue.
Summary: SitePerProcessBrowserTest.ChildFrameCrashMetrics tests are flaky on Android (was: SitePerProcessBrowserTest.ChildFrameCrashMetrics_KilledWhileVisible is flaky)
sadrul: Ping, are you taking a look at this?
Also seen in MSE_ExternalClearKey/EncryptedMediaTest.ConfigChangeVideo_EncryptedToClear/0

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/4024

Sign in to add a comment