Issue metadata
Sign in to add a comment
|
Assistant typing options: contrast too low for logo, text |
||||||||||||||||||||||||
Issue descriptionGoogle Chrome 72.0.3623.3 (Official Build) dev (64-bit) Firmware Version Google_Eve.9584.174.0 Steps: # Use a Chromebook with assistant built in, I used Eve # Enable Assistant's wake word "OK Google" # Say "OK Google" to launch Assistant UI # Examine the keyboard icon in the lower left corner Expected: contrast ratio of 4.5:1 or higher Actual: Foreground: #7e8486 Background: #ffffff Ratio: 3.80 # Invoke the icon to be able to enter text, examine "Type a message" text Expected: contrast ratio of 4.5:1 or higher Actual: Foreground: #aaafb0 Background: #ffffff Ratio: 2.22
,
Dec 1
,
Dec 1
Do we color icons in code or is it delivered through assets? If through assets, let me know but we should change it to be colored in code. Both icons and text color should be changed to #5F6368. Making contrast ratio 6.04.
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c366585861d3715a71dba1a407b45a8ec07b47c3 commit c366585861d3715a71dba1a407b45a8ec07b47c3 Author: Xiaohui Chen <xiaohuic@google.com> Date: Fri Dec 07 18:23:39 2018 assistant: update icon colors Increase the contrast for a11y. Bug: 910560 Test: locally build and run Change-Id: I1b8bb4d000902cd2db7349a4ca6cc63fd02f6853 Reviewed-on: https://chromium-review.googlesource.com/c/1366324 Reviewed-by: Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#614751} [modify] https://crrev.com/c366585861d3715a71dba1a407b45a8ec07b47c3/ash/assistant/util/views_util.h
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f45c44f94b374c9bceffc0d8985781506ab01425 commit f45c44f94b374c9bceffc0d8985781506ab01425 Author: Xiaohui Chen <xiaohuic@google.com> Date: Fri Dec 07 20:53:04 2018 assistant: update input text hint color Increase the contrast for a11y. Bug: 910560 Test: locally build and run Change-Id: Iedd3fc2ffa45ca6c637afcc046ff0c35a826f9ab Reviewed-on: https://chromium-review.googlesource.com/c/1368110 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#614807} [modify] https://crrev.com/f45c44f94b374c9bceffc0d8985781506ab01425/ash/assistant/ui/assistant_ui_constants.h
,
Dec 7
leberly@ and sgabriel@, what would you think would be a good color for the low confidence speech? We will either have low contrast between high/low confidence speech or low contrast between low confidence speech/background.
,
Dec 11
The minimum value you can have here here #6E747A before it goes under 4.5. Visually it is very very close to the #5F6368 used here (see image attached). Unless we want to change the treatment of high/low confidence speech (other color or weight), we'll have to stick with this or be ok with low confidence not being accessible.
,
Dec 11
sgabriel@ are you recommending to change the low confidence to #6E747A or keep it as #5F6368?
,
Dec 11
I'm recommending to stick with #5F6368 as it is a color consistent with our color system and the GM2 color system.
,
Dec 14
sgtm. That should be what the code base is right now. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by xiaohuic@google.com
, Nov 30