New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 910555 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

diagnostics: remove grpc/common.proto file

Project Member Reported by lamzin@google.com, Nov 30

Issue description

File grpc/common.proto is unused now.
 
Components: Internals>Core
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7962804911926b8f0be052acab774ddf87ee2ca3

commit 7962804911926b8f0be052acab774ddf87ee2ca3
Author: Oleh Lamzin <lamzin@google.com>
Date: Sun Dec 02 05:19:17 2018

diagnostics: remove grpc/common.proto file

Remove unused grpc/common.proto file.

BUG= chromium:910555 
TEST=the diagnostics package builds

Change-Id: Icacb66799fc4965c20bbfd84198186f50307cb19
Reviewed-on: https://chromium-review.googlesource.com/1356741
Commit-Ready: Oleh Lamzin <lamzin@google.com>
Tested-by: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>

[delete] https://crrev.com/d79ed8b4d7f4b29d65e2a96bc422fe943636c5f3/diagnostics/grpc/common.proto
[modify] https://crrev.com/7962804911926b8f0be052acab774ddf87ee2ca3/diagnostics/dpsl/public/dpsl_requester.h
[modify] https://crrev.com/7962804911926b8f0be052acab774ddf87ee2ca3/diagnostics/dpsl/demo_single_thread/main.cc
[modify] https://crrev.com/7962804911926b8f0be052acab774ddf87ee2ca3/diagnostics/diagnosticsd/fake_diagnostics_processor.h
[modify] https://crrev.com/7962804911926b8f0be052acab774ddf87ee2ca3/diagnostics/diagnosticsd/diagnosticsd_grpc_service.h
[modify] https://crrev.com/7962804911926b8f0be052acab774ddf87ee2ca3/diagnostics/dpsl/internal/dpsl_requester_impl.cc
[modify] https://crrev.com/7962804911926b8f0be052acab774ddf87ee2ca3/diagnostics/dpsl/public/dpsl_rpc_handler.h
[modify] https://crrev.com/7962804911926b8f0be052acab774ddf87ee2ca3/diagnostics/diagnostics.gyp
[modify] https://crrev.com/7962804911926b8f0be052acab774ddf87ee2ca3/diagnostics/dpsl/internal/dpsl_rpc_server_impl.h
[modify] https://crrev.com/7962804911926b8f0be052acab774ddf87ee2ca3/diagnostics/grpc/diagnosticsd.proto
[modify] https://crrev.com/7962804911926b8f0be052acab774ddf87ee2ca3/diagnostics/grpc/diagnostics_processor.proto

Oleh, should we close?
Status: Fixed (was: Started)
Thanks for remind!

Sign in to add a comment