New issue
Advanced search Search tips

Issue 910546 link

Starred by 1 user
Status: Available
Owner:
kolos@chromium.org
Cc:
battre@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Crowdsource button title to improve password generation classifications

Project Member Reported by kolos@chromium.org, Nov 30 
Crowdsourcing of form submission button title would provide an additional signal for form type classification. The form type classification is crucial to offer relevant functions of the password manager (e.g. fill credential on sign-in forms, generate passwords on sign-up forms, fill and generated on change password form).

Design doc: https://goo.gl/CFFbtf (Google internal)

Comment 1 by kolos@chromium.org, Nov 30

Cc: battre@chromium.org
Dominic: just in case you are interested in tracking the progress.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b06b519c811dd66aa9582ff8b7ef350443ec171e

commit b06b519c811dd66aa9582ff8b7ef350443ec171e
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Tue Dec 04 09:52:43 2018

[Password Generation] Add button titles to the server proto

Bug: 910546
Change-Id: Ie93e5e5266e6c1753255f28d942f5bc63a2a09a8
Reviewed-on: https://chromium-review.googlesource.com/c/1356546
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613488}
[modify] https://crrev.com/b06b519c811dd66aa9582ff8b7ef350443ec171e/components/autofill/core/browser/proto/server.proto
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e680e53d94c0bd796c04dbfdc4a81e7ffb2b05a

commit 5e680e53d94c0bd796c04dbfdc4a81e7ffb2b05a
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Wed Dec 05 12:06:58 2018

[Password Generation] Crowdsource form submission button's title

Button titles will be used to improve the password generation classifiers.

Bug: 910546
Change-Id: Ib2d819eab408768d3cbf95e6ee6139cfb47cf877
Reviewed-on: https://chromium-review.googlesource.com/c/1356591
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613944}
[modify] https://crrev.com/5e680e53d94c0bd796c04dbfdc4a81e7ffb2b05a/components/autofill/content/common/autofill_types.mojom
[modify] https://crrev.com/5e680e53d94c0bd796c04dbfdc4a81e7ffb2b05a/components/autofill/content/common/autofill_types_struct_traits.cc
[modify] https://crrev.com/5e680e53d94c0bd796c04dbfdc4a81e7ffb2b05a/components/autofill/content/common/autofill_types_struct_traits.h
[modify] https://crrev.com/5e680e53d94c0bd796c04dbfdc4a81e7ffb2b05a/components/autofill/content/common/autofill_types_struct_traits_unittest.cc
[modify] https://crrev.com/5e680e53d94c0bd796c04dbfdc4a81e7ffb2b05a/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/5e680e53d94c0bd796c04dbfdc4a81e7ffb2b05a/components/autofill/content/renderer/form_autofill_util.h
[modify] https://crrev.com/5e680e53d94c0bd796c04dbfdc4a81e7ffb2b05a/components/autofill/content/renderer/form_autofill_util_browsertest.cc
[modify] https://crrev.com/5e680e53d94c0bd796c04dbfdc4a81e7ffb2b05a/components/autofill/core/browser/autofill_test_utils.cc
[modify] https://crrev.com/5e680e53d94c0bd796c04dbfdc4a81e7ffb2b05a/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/5e680e53d94c0bd796c04dbfdc4a81e7ffb2b05a/components/autofill/core/browser/form_structure.h
[modify] https://crrev.com/5e680e53d94c0bd796c04dbfdc4a81e7ffb2b05a/components/autofill/core/browser/proto/server.proto
[modify] https://crrev.com/5e680e53d94c0bd796c04dbfdc4a81e7ffb2b05a/components/autofill/core/common/BUILD.gn
[add] https://crrev.com/5e680e53d94c0bd796c04dbfdc4a81e7ffb2b05a/components/autofill/core/common/button_title_type.h
[modify] https://crrev.com/5e680e53d94c0bd796c04dbfdc4a81e7ffb2b05a/components/autofill/core/common/form_data.cc
[modify] https://crrev.com/5e680e53d94c0bd796c04dbfdc4a81e7ffb2b05a/components/autofill/core/common/form_data.h
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/574fb069464fd1cc8f6080ec80176b16a8f0cfcc

commit 574fb069464fd1cc8f6080ec80176b16a8f0cfcc
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Wed Jan 02 22:16:01 2019

[Password Generation] Improve heuristics for button title detection

New heuristics look for <a>, <div> and <span> tags that contain button features (e.g. "button", "submit") in id/name/class attributes.

Button titles are crowdsourced and used for better password generation
classification.

Bug: 910546
Change-Id: I162353a480065e80403a1eebafccceb428c80e43
Reviewed-on: https://chromium-review.googlesource.com/c/1367659
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619514}
[modify] https://crrev.com/574fb069464fd1cc8f6080ec80176b16a8f0cfcc/components/autofill/content/common/autofill_types.mojom
[modify] https://crrev.com/574fb069464fd1cc8f6080ec80176b16a8f0cfcc/components/autofill/content/common/autofill_types_struct_traits.cc
[modify] https://crrev.com/574fb069464fd1cc8f6080ec80176b16a8f0cfcc/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/574fb069464fd1cc8f6080ec80176b16a8f0cfcc/components/autofill/content/renderer/form_autofill_util_browsertest.cc
[modify] https://crrev.com/574fb069464fd1cc8f6080ec80176b16a8f0cfcc/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/574fb069464fd1cc8f6080ec80176b16a8f0cfcc/components/autofill/core/browser/proto/server.proto
[modify] https://crrev.com/574fb069464fd1cc8f6080ec80176b16a8f0cfcc/components/autofill/core/common/button_title_type.h
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b10d833d445b7fedb7901e7323af48538b62fa8

commit 2b10d833d445b7fedb7901e7323af48538b62fa8
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Thu Jan 03 21:56:20 2019

[Autofill] Add |is_form_tag| to the server proto

Whether an uploaded form is a <form> tag or a list of unowned <input>s may be useful for server side analysis.
In particular, the list of unowned <input>s can contain several semantic forms (e.g. a search field,  sign-in form, sign-up form). The server side classifiers may apply special heuristics for the <form>less forms.

Bug: 552420, 910546
Change-Id: If4a5ec04eb1c0d87ec3a8cd399d84e3f5c31a692
Reviewed-on: https://chromium-review.googlesource.com/c/1394583
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619772}
[modify] https://crrev.com/2b10d833d445b7fedb7901e7323af48538b62fa8/chrome/browser/autofill/autofill_server_browsertest.cc
[modify] https://crrev.com/2b10d833d445b7fedb7901e7323af48538b62fa8/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/2b10d833d445b7fedb7901e7323af48538b62fa8/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/2b10d833d445b7fedb7901e7323af48538b62fa8/components/autofill/core/browser/proto/server.proto
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aba15f91a3d6563d2af8574528a096e2023d9146

commit aba15f91a3d6563d2af8574528a096e2023d9146
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Jan 04 08:41:16 2019

[Password Generation] Crowdsource button titles for <form>less forms.

TODO: Measure the performance of the button titles heuristics and consider optimisations.

Bug: 910546
Change-Id: Ic54111a4d8613578e216bd75deeeb5656871e89d
Reviewed-on: https://chromium-review.googlesource.com/c/1392092
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619899}
[modify] https://crrev.com/aba15f91a3d6563d2af8574528a096e2023d9146/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/aba15f91a3d6563d2af8574528a096e2023d9146/components/autofill/content/renderer/form_autofill_util.h
[modify] https://crrev.com/aba15f91a3d6563d2af8574528a096e2023d9146/components/autofill/content/renderer/form_autofill_util_browsertest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8e92eed356ea4c267266789549dc4fc0b91d122

commit c8e92eed356ea4c267266789549dc4fc0b91d122
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Jan 04 10:55:03 2019

[Password Generation] Don't crowdsource duplicate button titles

Bug: 910546
Change-Id: I2b9e0e7677cbc3f0f4ac7ac2722ba5d01d416efb
Reviewed-on: https://chromium-review.googlesource.com/c/1394529
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619908}
[modify] https://crrev.com/c8e92eed356ea4c267266789549dc4fc0b91d122/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/c8e92eed356ea4c267266789549dc4fc0b91d122/components/autofill/content/renderer/form_autofill_util_browsertest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1abb542130f5607a0233d5f741bc28d07fbeb11

commit c1abb542130f5607a0233d5f741bc28d07fbeb11
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Jan 04 16:18:10 2019

[Password Generation] Missed <body> tag shouldn't crash button titles detection

Bug:  919089 ,  919088 , 910546
Change-Id: I0ce5a28ccf7f13cfa6fda547b628fbe6cf4d9a83
Reviewed-on: https://chromium-review.googlesource.com/c/1396032
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619965}
[modify] https://crrev.com/c1abb542130f5607a0233d5f741bc28d07fbeb11/components/autofill/content/renderer/form_autofill_util.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b6f1a890fbf87634ea0e3e8ffda65c6e5d80248

commit 0b6f1a890fbf87634ea0e3e8ffda65c6e5d80248
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Mon Jan 07 10:34:47 2019

[Password Generation] Add performance metrics for button titles detection

Bug: 910546
Change-Id: I3db33f19d802c17d2816663eb1e5dad6e7679bc5
Reviewed-on: https://chromium-review.googlesource.com/c/1396127
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620283}
[modify] https://crrev.com/0b6f1a890fbf87634ea0e3e8ffda65c6e5d80248/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/0b6f1a890fbf87634ea0e3e8ffda65c6e5d80248/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment