Canary crashes when entering Settings>Passwords>Password details |
||||||||
Issue descriptionChrome Version: 72.0.3626.0 OS: iOS What steps will reproduce the problem? (1) Open Chrome; (2) Enter Settings; (3) Enter Passwords; (4) Tap on one of the saved passwords, of blacklisted sites. What is the expected result? The password details controller should be shown. What happens instead? The APP crashes.
,
Nov 30
Only reproduce on Canary.
,
Nov 30
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17c608f8c2aed5a20a7f9e1a1ed5002b48175502 commit 17c608f8c2aed5a20a7f9e1a1ed5002b48175502 Author: Yi Su <mrsuyi@chromium.org> Date: Fri Nov 30 19:04:31 2018 Fix password settings crash by modifying property attributes of TableViewTextItem.textColor. The Canary crashes when a TableViewTextItem configures its cell and checks its "textColor" property, which is "assign" and might get released after assigned. This CL fixes it by changing the property's "assign" attribute to "strong" so that the UIColor object will be retained. Bug: 910542 Change-Id: I44b6a60c52c5a470e69a44ca6670720446ef084b Reviewed-on: https://chromium-review.googlesource.com/c/1356585 Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612716} [modify] https://crrev.com/17c608f8c2aed5a20a7f9e1a1ed5002b48175502/ios/chrome/browser/ui/table_view/cells/table_view_text_item.h
,
Dec 1
,
Dec 2
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 3
,
Dec 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8d71950d8407783d5cea585ad7e3cabefa1cf66 commit e8d71950d8407783d5cea585ad7e3cabefa1cf66 Author: Yi Su <mrsuyi@chromium.org> Date: Mon Dec 03 09:01:16 2018 Fix password settings crash by modifying property attributes of TableViewTextItem.textColor. The Canary crashes when a TableViewTextItem configures its cell and checks its "textColor" property, which is "assign" and might get released after assigned. This CL fixes it by changing the property's "assign" attribute to "strong" so that the UIColor object will be retained. Bug: 910542 Change-Id: I44b6a60c52c5a470e69a44ca6670720446ef084b Reviewed-on: https://chromium-review.googlesource.com/c/1356585 Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612716}(cherry picked from commit 17c608f8c2aed5a20a7f9e1a1ed5002b48175502) Reviewed-on: https://chromium-review.googlesource.com/c/1356809 Reviewed-by: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#7} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/e8d71950d8407783d5cea585ad7e3cabefa1cf66/ios/chrome/browser/ui/table_view/cells/table_view_text_item.h
,
Dec 3
Issue 911091 has been merged into this issue.
,
Dec 4
Issue verified Version: Chrome Canary 73.0.3629.0 Device: iPhone 8 iOS: 12.1 App does not crash entering Settings>Passwords>Password details https://drive.google.com/open?id=1RpczEjw_cyeKlPg6S0zwILuYoMttHO11
,
Dec 12
Issue verified Version: Chrome Beta 72.0.3626.15 Device: iPhone XS, iPad 2018 iOS: 12.1 No crash observed by entering Settings>Passwords>Password details https://drive.google.com/open?id=1yl5czSsMdkpdzgsYR073E9CE22rU8WVu
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8d71950d8407783d5cea585ad7e3cabefa1cf66 Commit: e8d71950d8407783d5cea585ad7e3cabefa1cf66 Author: mrsuyi@chromium.org Commiter: mrsuyi@chromium.org Date: 2018-12-03 09:01:16 +0000 UTC Fix password settings crash by modifying property attributes of TableViewTextItem.textColor. The Canary crashes when a TableViewTextItem configures its cell and checks its "textColor" property, which is "assign" and might get released after assigned. This CL fixes it by changing the property's "assign" attribute to "strong" so that the UIColor object will be retained. Bug: 910542 Change-Id: I44b6a60c52c5a470e69a44ca6670720446ef084b Reviewed-on: https://chromium-review.googlesource.com/c/1356585 Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612716}(cherry picked from commit 17c608f8c2aed5a20a7f9e1a1ed5002b48175502) Reviewed-on: https://chromium-review.googlesource.com/c/1356809 Reviewed-by: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#7} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mrsuyi@chromium.org
, Nov 30