Issue metadata
Sign in to add a comment
|
Permission Bubble should be ON TOP of Omnibox Dropdown On Mac
Reported by
avsha...@etouch.net,
Nov 30
|
||||||||||||||||||||
Issue descriptionChrome Version : 72.0.3626.0 (Official Build) edf89be4ed3da140d2558a9a575ca0e6da65e5de-refs/branch-heads/3626@{#1} 64 bit OS : Mac(10.13.6, 10.13.1, 10.14.2) What steps will reproduce the problem? 1. Launch chrome, open NTP and click on 'Microphone' icon present in fake box. 2. Keep permission bubble open and hit 'Alt + Command + F' keys. 3. Observe the left hand side in omnibox. Actual Result : Unwanted curved shadow is seen in omnibox on opening suggestions list. Expected Result : Curved shadow should not be seen in omnibox on opening suggestions list. This is a regression issue broken in M-70 and below is the bisect information: Good Build : 70.0.3503.0 (Revision : 578160) Bad Build : 70.0.3504.0 (Revision : 578510) Change-Log URL: https://chromium.googlesource.com/chromium/src/+log/bcb7db78edc13f57577f0a9562c98918bdcc10ae..67d21d10815fe6d87d1785a65a50fbc386e6605b Suspect: https://chromium.googlesource.com/chromium/src/+/67d21d10815fe6d87d1785a65a50fbc386e6605b @ellyjones: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. This is Mac OS specific issue and same is not seen in Windows(7,8,10) and Linux(14.04 LTS) OS 2. Issue is reproducible in Stable #70.0.3538.110 and Dev #72.0.3622.0 Thank you..!
,
Nov 30
-> Untriaged so the omnibox triage will pick it up
,
Dec 3
The bisect (thanks avshaikh) is a feature-enable for ViewsBrowserWindows, so it might be different behavior between the two implementations.
,
Dec 3
Root cause is that the permission info dialog appears UNDER the Omnibox dropdown window on Mac. On Linux and Windows, it appears OVER the dropdown window, so it doesn't look broken. I'm assigning this to avi@ as he has helped us with the Omnibox dropdown on Mac before. Thanks!
,
Dec 3
The attached screenshot in the previous comment is how it looks like on Windows.
,
Jan 8
The Windows / Linux equivalent of Alt+Ctrl+F should be Ctrl+K, FYI.
,
Jan 8
On Win/Lin, the ordering is "correct": permission bubble on top of omnibox beard. The Mac behavior makes sense in a programmatic way, though. The permission dialog is added as a child, then the omnibox beard is added, so the beard is on top of the permission dialog. Why does Win/Lin put the children the other way around? I'm hunting through the code and haven't yet found the answer.
,
Jan 8
This is less than ideal, but I don't see this as P1. Probably a P3, maybe a P2. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ellyjo...@chromium.org
, Nov 30