New issue
Advanced search Search tips

Issue 910531 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Few websites can’t be set as a default search engine

Project Member Reported by rakurati@chromium.org, Nov 30

Issue description

App Version: 72.0.3626.0 Canary
iOS Version: 10.3.3, 11.4.1, 12.1.1 beta#3
Device: iPhone and iPad                                                                                                                                                                                                                                                                            

Steps to reproduce:
1. Launch chrome (Perform Clear browsing data if the app is not fresh installed) 
2. Go to youtube.com
3. Search for any keyword
4. Go to settings>>Search Engine

Observed results:
Notice that youtube.com are not listed in search engine

Note 1: In Chrome Desktop, able to set youtube.com as a default search engine
Note 2: Similarly not able to set other websites like wikipedia.org, wolframalpha.com, etc..
Note 3: Able to set cnn.com/baidu.com/chromium.org an as a default search engine

Expected results:
Should be able to set as a default search engine

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Chrome Desktop: No
Bug reproducible on Chrome Mobile on Android: Yes
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): NA on M70 (Feature is available form M72)
Bug reproducible on the current beta channel build (App Version, iOS Version): NA on M71 beta (Feature is available form M72)

Link to Video:
Chrome iOS behavior:
https://drive.google.com/file/d/1s5GWO8FHr1WBpxYWX2GAMLBprO24rUR5/view?usp=sharing

Chrome Desktop  behavior:
https://drive.google.com/file/d/1GJt19TWIJhLt1XNE-Kr4BEx0K_XMvoDJ/view?usp=sharing

 
Owner: mrsuyi@chromium.org
Status: Assigned (was: Untriaged)
For youtube.com, desktop and mobile devices receive different web pages. The page for desktop contains the OSDD(Open Search Description Document) <link>, and the page for mobile devices doesn't. That's the reason why youtube.com on iPhone(and Android I guess) is not added to the list.

Do following steps to check it:
1. Open Desktop Chrome;
2. Open Debug panel;
3. Change to mobile mode by clicking the button on the left top corner;
4. Open youtube.com;
5. Check the Settings>SearchEngines. The "youtube.com" is not added.

wolframalpha.com has the same issue as youtube.com.

For other web pages that don't have a OSDD <link> on both desktop and mobile versions, there might be differences between <form>s on desktop and on mobile, which prevents the page from being added to the list. wikipedia.org seems to be in this case, I'll check it later.

For the youtube.com case, you may want to consider filing an internal bug.
mpearson@ I've fired a bug for youtube.com (120535966).

For wikipedia, visiting it on mobile device will redirect you to the mobile version(e.g. https://en.m.wikipedia.org/wiki/Main_Page), which has too many sections in URL's path thus cannot generate a keyword. Code logic:
iOS:
https://cs.chromium.org/chromium/src/ios/chrome/browser/search_engines/search_engine_tab_helper.mm?rcl=7fa1000f175eeb5e0ee75287ab8c69feb13fdd2d&l=66
Other platforms:
https://cs.chromium.org/chromium/src/chrome/browser/ui/search_engines/search_engine_tab_helper.cc?rcl=7fa1000f175eeb5e0ee75287ab8c69feb13fdd2d&l=65

So wikipedia cannot be added as custom search engine on Desktop if you open debug window and switch to mobile mode. I've tested that.

If we want to fix it, we should fix it on all platforms to be consistent, and I think we should mark this bug as WontFix as we have not found any search engine website that can be added as custom search engine on Android but not on iOS.
Cc: pkasting@chromium.org
+pkasting@ WDYT?
The original reason for the path constraint was the assumption that if a search engine has a path, the same host might well have multiple search engines, and we didn't want them warring with each other.

Perhaps this isn't always true and we should relax this constraint (everywhere).  I'm not sure.
I think this is a useful path limitation is likely a useful heuristic constraint.  I know that I often search help pages in retailer web sites, and don't want those clobbering the default search for items on the web site.  (Not sure if they would, just concerned.)

Cc: mrsuyi@chromium.org
Issue 917365 has been merged into this issue.

Sign in to add a comment