Issue metadata
Sign in to add a comment
|
Regression: Unwanted space is seen on RHS of the window while putting back it into main window
Reported by
db...@etouch.net,
Nov 30
|
||||||||||||||||||||
Issue descriptionChrome Version: 72.0.3626.0 Revision edf89be4ed3da140d2558a9a575ca0e6da65e5de-refs/branch-heads/3626@{#1}(32/64 bit) OS: Windows(7,8,10), Linux(14.04 LTS) What steps will reproduce the problem? (1) Launch chrome, navigate to any web page(ex.https://chrome.google.com/webstore?hl=en) (2) Now hold this tab & drag it outside and again try to put back in main window without releasing the hold. (3) Observe RHS of the window while putting back it. Actual: Unwanted space is seen on RHS of the window while putting back it. Expected: No such a space should seen on RHS of the window while putting back it. This is a regression issue, broken in 'M72'., below is bisect info: Good Build:72.0.3616.0 Bad Build: 72.0.3617.0 You are probably looking for a change made after 609832 (known good), but no later than 609833 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/d1e093c27066ce5de912a69813f95593ad6f6de4..6ae479b5587e5e97b3dc8282f4c91dd05ec6ef11 Suspect: https://chromium.googlesource.com/chromium/src/+/6ae479b5587e5e97b3dc8282f4c91dd05ec6ef11 xdai@: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Issue is not seen on Mac(10.13.1,10.13.6,10.14.2) OS.
,
Dec 13
,
Dec 13
It did caused by my CL, however, unless I revert my CL, there is probably no good way to fix it. My CL was to improve the tab-dragging smoothness, especially for a heavy webpage on Chrome OS tablet mode, see comparison before https://drive.google.com/file/d/1aN02WfhPo-qd33EzQgbTQUSYpoAupXm_/view and after https://drive.google.com/file/d/1GjJteBEu29Q_8i8zubRyYbXYgA9Mkm_g/view. Theoretically the CL should improve the smoothness on Linux and Windows as well, since during tab-dragging, we no longer resize the webcontents on the fly, but will wait to do so after drag ends, which also explains why the unwanted space can be seen when merging the tabs back to its source window without releasing the mouse or touch. The unwanted space can also be observed on Chrome OS, but is not as bad as we saw here on Linux and Windows IMO, mainly because the page slider bar does not show on Chrome OS when merging the dragged tab back. I want to know how bad this issue is? If it's really bad, I probably can enable my CL on Chrome OS only. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by x...@chromium.org
, Nov 30