Update :
Bisect info:
You are probably looking for a change made after 612169 (known good), but no later than 612170 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/34c52daf88e484232cc4d458b7a98255112c6c52..cc13e7ebdd1c65894fc16f3bdacdf36aef19d9f9

Suspect: https://chromium.googlesource.com/chromium/src/+/cc13e7ebdd1c65894fc16f3bdacdf36aef19d9f9


@David Roger :Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.	


Thank You!

marking as RBB, please change if required

Thanks for this report, that was very useful.
This is indeed caused by my change.

I'm working on a fix now.

 Issue 910494  has been merged into this issue.

droger@, thank you for helping with the fix here, Friendly reminder, BETA release is next week on dec 13. 

droger@, just wondering do we have any latest updates on the fix?

Friendly ping to get an update as Beta release is coming soon this week.
Thanks..!

The fix is in review here:
https://chromium-review.googlesource.com/c/chromium/src/+/1358499

hopefully it should land soon.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1281aa2b06be40e78271c1815e98d645e6a16a74

commit 1281aa2b06be40e78271c1815e98d645e6a16a74
Author: David Roger <droger@chromium.org>
Date: Mon Dec 10 10:13:23 2018

[signin] Update Profile/BrowserState info on signin events

The SigninProfileAttributesUpdater was not registered as an observer for
the SigninManager, and the profile info was not updated correctly.

This CL adds the missing registration call as well as unittests.

Bug:  910506 
Change-Id: I59ce42bf6a51afa3371ed97cae6a4d9789be3f67
Reviewed-on: https://chromium-review.googlesource.com/c/1358499
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615076}
[modify] https://crrev.com/1281aa2b06be40e78271c1815e98d645e6a16a74/chrome/browser/signin/signin_profile_attributes_updater.cc
[modify] https://crrev.com/1281aa2b06be40e78271c1815e98d645e6a16a74/chrome/browser/signin/signin_profile_attributes_updater.h
[add] https://crrev.com/1281aa2b06be40e78271c1815e98d645e6a16a74/chrome/browser/signin/signin_profile_attributes_updater_unittest.cc
[modify] https://crrev.com/1281aa2b06be40e78271c1815e98d645e6a16a74/chrome/test/BUILD.gn
[modify] https://crrev.com/1281aa2b06be40e78271c1815e98d645e6a16a74/ios/chrome/browser/signin/BUILD.gn
[modify] https://crrev.com/1281aa2b06be40e78271c1815e98d645e6a16a74/ios/chrome/browser/signin/signin_browser_state_info_updater.h
[modify] https://crrev.com/1281aa2b06be40e78271c1815e98d645e6a16a74/ios/chrome/browser/signin/signin_browser_state_info_updater.mm
[add] https://crrev.com/1281aa2b06be40e78271c1815e98d645e6a16a74/ios/chrome/browser/signin/signin_browser_state_info_updater_unittest.mm

[Auto-generated comment by a script] We noticed that this issue is targeted for M-72; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-72 label, otherwise remove Merge-TBD label. Thanks.

droger@ can you please remove the merge-tbd label and add 72 merge label, if this change needs to be merged to 72 branch.

Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c244328206e0bde796a7fc8ddf65e8638dc1f5e

commit 5c244328206e0bde796a7fc8ddf65e8638dc1f5e
Author: David Roger <droger@chromium.org>
Date: Wed Dec 12 10:21:57 2018

[signin] Update Profile/BrowserState info on signin events

The SigninProfileAttributesUpdater was not registered as an observer for
the SigninManager, and the profile info was not updated correctly.

This CL adds the missing registration call as well as unittests.

TBR=droger@chromium.org

(cherry picked from commit 1281aa2b06be40e78271c1815e98d645e6a16a74)

Bug:  910506 
Change-Id: I59ce42bf6a51afa3371ed97cae6a4d9789be3f67
Reviewed-on: https://chromium-review.googlesource.com/c/1358499
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615076}
Reviewed-on: https://chromium-review.googlesource.com/c/1373709
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#280}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/5c244328206e0bde796a7fc8ddf65e8638dc1f5e/chrome/browser/signin/signin_profile_attributes_updater.cc
[modify] https://crrev.com/5c244328206e0bde796a7fc8ddf65e8638dc1f5e/chrome/browser/signin/signin_profile_attributes_updater.h
[add] https://crrev.com/5c244328206e0bde796a7fc8ddf65e8638dc1f5e/chrome/browser/signin/signin_profile_attributes_updater_unittest.cc
[modify] https://crrev.com/5c244328206e0bde796a7fc8ddf65e8638dc1f5e/chrome/test/BUILD.gn
[modify] https://crrev.com/5c244328206e0bde796a7fc8ddf65e8638dc1f5e/ios/chrome/browser/signin/BUILD.gn
[modify] https://crrev.com/5c244328206e0bde796a7fc8ddf65e8638dc1f5e/ios/chrome/browser/signin/signin_browser_state_info_updater.h
[modify] https://crrev.com/5c244328206e0bde796a7fc8ddf65e8638dc1f5e/ios/chrome/browser/signin/signin_browser_state_info_updater.mm
[add] https://crrev.com/5c244328206e0bde796a7fc8ddf65e8638dc1f5e/ios/chrome/browser/signin/signin_browser_state_info_updater_unittest.mm

Looks like cherrypick in comment 16 broke iOS M72 branch release build:
  https://uberchromegw.corp.google.com/i/official.ios/builders/ios/builds/3177

Compilation failed.

To properly revert cherrypick on comment 16, we need to revert 2 CLs:

CL 2 - https://chromium-review.googlesource.com/c/1375120
  5958ebb18d6c7d40fd4fa8969a287ca3bca1aaa9

CL 1 - https://chromium-review.googlesource.com/c/1358499
  5c244328206e0bde796a7fc8ddf65e8638dc1f5e

CL 2 modified a file that was added in CL 1, you cannot just revert the CL 1 without reverting CL 2 first.

Please do not revert upstream CL breaking downstream bots. I can't access the log now, but I'll take a look tomorrow. Alternately this may be something that the bling sheriff or person on merge rotation may be able to fix.

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/5c244328206e0bde796a7fc8ddf65e8638dc1f5e

Commit: 5c244328206e0bde796a7fc8ddf65e8638dc1f5e
Author: droger@chromium.org
Commiter: droger@chromium.org
Date: 2018-12-12 10:21:57 +0000 UTC

[signin] Update Profile/BrowserState info on signin events

The SigninProfileAttributesUpdater was not registered as an observer for
the SigninManager, and the profile info was not updated correctly.

This CL adds the missing registration call as well as unittests.

TBR=droger@chromium.org

(cherry picked from commit 1281aa2b06be40e78271c1815e98d645e6a16a74)

Bug:  910506 
Change-Id: I59ce42bf6a51afa3371ed97cae6a4d9789be3f67
Reviewed-on: https://chromium-review.googlesource.com/c/1358499
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615076}
Reviewed-on: https://chromium-review.googlesource.com/c/1373709
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#280}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}