Issue metadata
Sign in to add a comment
|
Regression : Unnecessarily 'All Apps' icon is seen from shelf after clicking on App Launcher Icon |
||||||||||||||||||||||
Issue descriptionChrome Version: 72.0.3625.0/11315.0.0 dev-channel Candy,Blaze and Celes OS: Chrome What steps will reproduce the problem? (1)Sign into User -> now click on App Launcher Icon -> observe unnecessarily 'All Apps' icon is seen from shelf (Please refer Video and Screenshot) Expected: Unnecessarily 'All Apps' icon should not be seen from shelf Actual: Instead unnecessarily 'All Apps' icon is seen from shelf This is Regression Issue as same is working fine on M-70 Note : Issue is also seen on M-71
,
Dec 5
,
Dec 6
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3dfd599299ec7fd63069e1c78542861de1a85314 commit 3dfd599299ec7fd63069e1c78542861de1a85314 Author: Alex Newcomer <newcomer@chromium.org> Date: Wed Dec 12 22:18:08 2018 cros: Add layers to bring the launcher open/close animation back This animation was removed unintentionally, this CL brings it back. Also added better comments so the animation's importance is more obvious. Bug: 910496 Change-Id: If505bea1683d7ae456dcedbdb0a9e97ea58e02de Reviewed-on: https://chromium-review.googlesource.com/c/1368604 Reviewed-by: Jenny Zhang <jennyz@chromium.org> Reviewed-by: Mitsuru Oshima (gardener - slow) <oshima@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#616080} [modify] https://crrev.com/3dfd599299ec7fd63069e1c78542861de1a85314/ash/app_list/presenter/app_list_presenter_impl.cc [modify] https://crrev.com/3dfd599299ec7fd63069e1c78542861de1a85314/ash/app_list/views/app_list_main_view.cc [modify] https://crrev.com/3dfd599299ec7fd63069e1c78542861de1a85314/ash/app_list/views/app_list_view.cc [modify] https://crrev.com/3dfd599299ec7fd63069e1c78542861de1a85314/ash/app_list/views/contents_view.cc [modify] https://crrev.com/3dfd599299ec7fd63069e1c78542861de1a85314/ash/app_list/views/contents_view.h
,
Dec 13
,
Dec 13
,
Dec 13
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59e70a33f384827211478868da84bd0ea9b4a07b commit 59e70a33f384827211478868da84bd0ea9b4a07b Author: Alex Newcomer <newcomer@chromium.org> Date: Thu Dec 13 18:08:50 2018 cros: Add layers to bring the launcher open/close animation back This animation was removed unintentionally, this CL brings it back. Also added better comments so the animation's importance is more obvious. Bug: 910496 Change-Id: If505bea1683d7ae456dcedbdb0a9e97ea58e02de Reviewed-on: https://chromium-review.googlesource.com/c/1368604 Reviewed-by: Jenny Zhang <jennyz@chromium.org> Reviewed-by: Mitsuru Oshima (gardener - slow) <oshima@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#616080}(cherry picked from commit 3dfd599299ec7fd63069e1c78542861de1a85314) Reviewed-on: https://chromium-review.googlesource.com/c/1376329 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#330} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/59e70a33f384827211478868da84bd0ea9b4a07b/ash/app_list/presenter/app_list_presenter_impl.cc [modify] https://crrev.com/59e70a33f384827211478868da84bd0ea9b4a07b/ash/app_list/views/app_list_main_view.cc [modify] https://crrev.com/59e70a33f384827211478868da84bd0ea9b4a07b/ash/app_list/views/app_list_view.cc [modify] https://crrev.com/59e70a33f384827211478868da84bd0ea9b4a07b/ash/app_list/views/contents_view.cc [modify] https://crrev.com/59e70a33f384827211478868da84bd0ea9b4a07b/ash/app_list/views/contents_view.h
,
Dec 19
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 59e70a33f384827211478868da84bd0ea9b4a07b was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59e70a33f384827211478868da84bd0ea9b4a07b Commit: 59e70a33f384827211478868da84bd0ea9b4a07b Author: newcomer@chromium.org Commiter: newcomer@chromium.org Date: 2018-12-13 18:08:50 +0000 UTC cros: Add layers to bring the launcher open/close animation back This animation was removed unintentionally, this CL brings it back. Also added better comments so the animation's importance is more obvious. Bug: 910496 Change-Id: If505bea1683d7ae456dcedbdb0a9e97ea58e02de Reviewed-on: https://chromium-review.googlesource.com/c/1368604 Reviewed-by: Jenny Zhang <jennyz@chromium.org> Reviewed-by: Mitsuru Oshima (gardener - slow) <oshima@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#616080}(cherry picked from commit 3dfd599299ec7fd63069e1c78542861de1a85314) Reviewed-on: https://chromium-review.googlesource.com/c/1376329 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#330} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by newcomer@chromium.org
, Dec 3