New issue
Advanced search Search tips

Issue 910489 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocking:
issue 894819



Sign in to add a comment

Move FtpDirectoryListingResponseDelegate to blink

Project Member Reported by yhirano@chromium.org, Nov 30

Issue description

Move it to blink to make deprecating WebDataConsumerHandle easy.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c31cc874025f7c2ef441925f85c0cba134d8d7ac

commit c31cc874025f7c2ef441925f85c0cba134d8d7ac
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Dec 04 08:10:14 2018

Remove FTP support from XHR

Intent thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/evZbY6LFq_s

Bug:  910990 ,  910489 
Change-Id: I37e1888dc8632e63aecdbf28ce91b7c2e8bc5949
Reviewed-on: https://chromium-review.googlesource.com/c/1360214
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613466}
[modify] https://crrev.com/c31cc874025f7c2ef441925f85c0cba134d8d7ac/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2046dd28639651936de4e8ec6b74fbf7a26c5545

commit 2046dd28639651936de4e8ec6b74fbf7a26c5545
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Dec 06 09:56:36 2018

Move FTP directory listing from content/renderer/loader to Blink

In order to WebDataConsumerHandle deprecation easy, move
content::FtpDirectoryListingResponseDelegate to blink.

Bug:  910489 
Change-Id: I878df1c90c28de1c3f44d9ed48e518207fa831c5
Reviewed-on: https://chromium-review.googlesource.com/c/1358315
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614298}
[modify] https://crrev.com/2046dd28639651936de4e8ec6b74fbf7a26c5545/content/renderer/BUILD.gn
[delete] https://crrev.com/11e903b61b49feff17e97ed5fe8060f23d16900e/content/renderer/loader/ftp_directory_listing_response_delegate.cc
[delete] https://crrev.com/11e903b61b49feff17e97ed5fe8060f23d16900e/content/renderer/loader/ftp_directory_listing_response_delegate.h
[modify] https://crrev.com/2046dd28639651936de4e8ec6b74fbf7a26c5545/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/2046dd28639651936de4e8ec6b74fbf7a26c5545/content/renderer/loader/web_url_loader_impl_unittest.cc
[modify] https://crrev.com/2046dd28639651936de4e8ec6b74fbf7a26c5545/content/renderer/loader/weburlresponse_extradata_impl.cc
[modify] https://crrev.com/2046dd28639651936de4e8ec6b74fbf7a26c5545/content/renderer/loader/weburlresponse_extradata_impl.h
[modify] https://crrev.com/2046dd28639651936de4e8ec6b74fbf7a26c5545/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/2046dd28639651936de4e8ec6b74fbf7a26c5545/third_party/blink/public/web/web_document_loader.h
[modify] https://crrev.com/2046dd28639651936de4e8ec6b74fbf7a26c5545/third_party/blink/renderer/core/exported/web_document_loader_impl.cc
[modify] https://crrev.com/2046dd28639651936de4e8ec6b74fbf7a26c5545/third_party/blink/renderer/core/exported/web_document_loader_impl.h
[modify] https://crrev.com/2046dd28639651936de4e8ec6b74fbf7a26c5545/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/2046dd28639651936de4e8ec6b74fbf7a26c5545/third_party/blink/renderer/core/loader/document_loader.h
[modify] https://crrev.com/2046dd28639651936de4e8ec6b74fbf7a26c5545/third_party/blink/renderer/platform/loader/BUILD.gn
[modify] https://crrev.com/2046dd28639651936de4e8ec6b74fbf7a26c5545/third_party/blink/renderer/platform/loader/DEPS
[add] https://crrev.com/2046dd28639651936de4e8ec6b74fbf7a26c5545/third_party/blink/renderer/platform/loader/ftp_directory_listing.cc
[add] https://crrev.com/2046dd28639651936de4e8ec6b74fbf7a26c5545/third_party/blink/renderer/platform/loader/ftp_directory_listing.h
[add] https://crrev.com/2046dd28639651936de4e8ec6b74fbf7a26c5545/third_party/blink/renderer/platform/loader/ftp_directory_listing_test.cc

Status: Fixed (was: Assigned)

Sign in to add a comment