Regression: Grey focus highlight gets lost and doesn't stay on 'More actions' icon of 'Export password'. |
||||
Issue descriptionChrome Version: 72.0.3626.0 (Official Build) Revision edf89be4ed3da140d2558a9a575ca0e6da65e5de-refs/branch-heads/3626@{#1} (32/64-bit) OS: Windows (7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2) & Linux(14.04 LTS). Pre-condition: At least one saved password entry must be present under chrome://settings/passwords What steps will reproduce the problem? 1. Launch Chrome and navigate to chrome://settings/passwords 2. Click on 'More actions' (3 dot) icon to open 'Export password' list. 3. Click on 'Export password' list to open 'Export password' overlay. 4. Now press 'Esc' key from keyboard and observe the focus. Actual: Grey focus highlight gets lost and doesn't stay on 'More actions' (3 dot) icon of export password after pressing 'Esc' key. Expected: Grey focus highlight should stay on 'More actions' icon of export password after pressing 'Esc' key. This is a regression issue, broken in M-72 series, below is manual regression range: Good build: 72.0.3604.0 (Revision: 605913) Bad build: 72.0.3605.0 (Revision: 606281) You are probably looking for a change made after 606237 (known good), but no later than 606238 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/e0c9eec9f74e4cd9cca5ef8c3980b6bc677c3cce..bebcb3a6f6fa34969a69121f42c0347934de6294 Suspecting: https://chromium.googlesource.com/chromium/src/+/bebcb3a6f6fa34969a69121f42c0347934de6294 @aee: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: This issue is also reproducible on Dev #72.0.3622.0 Kindly review the attached screen-cast for reference. Thank You..!
,
Dec 3
,
Dec 3
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29070b7eca6f4cdbf7c158ed9a38a78adb92cabb commit 29070b7eca6f4cdbf7c158ed9a38a78adb92cabb Author: Esmael El-Moslimany <aee@chromium.org> Date: Tue Dec 04 01:52:59 2018 Settings WebUI: password export dialog, send close event after any open dialog is removed from dom Bug: 910488 Change-Id: I566c42a2a6141d963b538208a400b38fcdc64e4e Reviewed-on: https://chromium-review.googlesource.com/c/1359292 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#613386} [modify] https://crrev.com/29070b7eca6f4cdbf7c158ed9a38a78adb92cabb/chrome/browser/resources/settings/autofill_page/passwords_export_dialog.js
,
Dec 4
,
Dec 5
Update: Rechecked this issue on Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2) and Linux(14.04) machines using latest Canary #73.0.3631.0 and issue is fixed. Hence adding TE-Verified labels. Please refer the attached screen-cast for reference. Thank you. |
||||
►
Sign in to add a comment |
||||
Comment 1 by dpa...@chromium.org
, Nov 30