New issue
Advanced search Search tips

Issue 910485 link

Starred by 0 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 900458



Sign in to add a comment

ECC: trunks: ECC key operations support in tpm_utility

Project Member Reported by menghuan@chromium.org, Nov 30

Issue description

For all key related functions

1. Support generate keys, CreateECCKeyPair which is ECC version of CreateRSAKeyPair
2. Support sign/verify with ECDSA
3. AsymmetricEncrypt/AsymmetricDecrypt
4. ECC version of ImportRSAKey
5. ECC version of LoadRSAPublicKey
etc.
 
Blocking: 900458
Labels: OS-Chrome
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3e10da53529f0bbd3a08dd4474c5e24a5b5e33fb

commit 3e10da53529f0bbd3a08dd4474c5e24a5b5e33fb
Author: Meng-Huan Yu <menghuan@chromium.org>
Date: Tue Dec 04 08:11:42 2018

trunks: set symmetric.algorithm to ALG_NULL in CreateDefaultPublicArea

For non-restrict keys, symmetric.algorithm should be TPM_ALG_NULL.
Make the default setting of ECC key set symmetric.algorithm to
TPM_ALG_NULL, just align with RSA one.

BUG=chromium:910485
TEST=pass trunks unitest

Change-Id: I89af466c2c1b514bd3efc3b44e1eaef2afa8e50e
Reviewed-on: https://chromium-review.googlesource.com/1356664
Commit-Ready: Meng-Huan Yu <menghuan@chromium.org>
Tested-by: Meng-Huan Yu <menghuan@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/3e10da53529f0bbd3a08dd4474c5e24a5b5e33fb/trunks/tpm_utility_impl.cc

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d7022b822cfae8c15ee684e48092a728ce501f51

commit d7022b822cfae8c15ee684e48092a728ce501f51
Author: Meng-Huan Yu <menghuan@chromium.org>
Date: Wed Dec 12 17:40:57 2018

trunks: small refactor for Sign/Verify in tpm_utility_impl.cc

Small refactor to make code logic much clean.

BUG=chromium:910485
TEST=passed unittest (it is expected no change of behavior)

Change-Id: Idae702d9bdd5db26c4b382717c3bb988aca2644d
Reviewed-on: https://chromium-review.googlesource.com/1356666
Commit-Ready: Meng-Huan Yu <menghuan@chromium.org>
Tested-by: Meng-Huan Yu <menghuan@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/d7022b822cfae8c15ee684e48092a728ce501f51/trunks/tpm_utility_impl.cc

Sign in to add a comment