Regression : Grey focus highlight on close icon overlaps with search box in chrome://settings/ page.
Reported by
rp...@etouch.net,
Nov 30
|
||||
Issue descriptionChrome Version: 72.0.3625.0 (Official Build) Revision 2c59a8a07afb8b11354406e63270d1cbeb582c47-refs/branch-heads/3625@{#1}(32/64-bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.14.2,10.13.1,10.13.6) Steps to reproduce: 1. Launch chrome, Navigate to chrome://settings/ 2. Change 'Font size' to 'Very small' from 'Appearance' section 3. Now click on 'Passwords' and type any text in 'Search passwords' search field such as close icon is seen 4. Now press 'Tab' key to bring focus on 'X' close icon,observe Actual Result : Grey focus highlight on close icon overlaps with search box Expected Result : Grey focus highlight on close icon shouldn't overlap with search box This is a regression issue broken in M-69 and below is the bisect information: Good Build : 69.0.3456.0 (Revision : 566382) Bad Build : 69.0.3457.0 (Revision : 566678) You are probably looking for a change made after 566530 (known good), but no later than 514231 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/8f68ca7f55a3606bf2a3c4ae836471a2f0536f3b..a28431dbf4972895460f4a085da668eb7e255826 Suspecting: https://chromium.googlesource.com/chromium/src/+/a28431dbf4972895460f4a085da668eb7e255826 @scottchen: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : Able to reproduce issue in Stable #70.0.3538.110 , Beta #71.0.3578.75 , Dev #72.0.3622.0. Kindly refer the attached screen cast. Thank You!
,
Dec 7
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f02c0f1a29ee970e07a9ac0d3bd0bb478116b4aa commit f02c0f1a29ee970e07a9ac0d3bd0bb478116b4aa Author: John Lee <johntlee@chromium.org> Date: Wed Dec 12 02:30:53 2018 WebUI: Make subpage search inputs take the full height of its containers to fix alignment issues Bug: 910476 Change-Id: If8d3676d21133f49b0e872bca84d389d0a8042f3 Reviewed-on: https://chromium-review.googlesource.com/c/1372416 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#615790} [modify] https://crrev.com/f02c0f1a29ee970e07a9ac0d3bd0bb478116b4aa/chrome/browser/resources/settings/settings_page/settings_subpage_search.html
,
Dec 12
,
Dec 13
Update : Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS) and Mac OS X(10.13.1,10.13.6,10.14.2) using latest Canary build : 73.0.3639.0 and the issue is Fixed.Hence adding TE Verified Labels. Kindly refer the attached screen cast for reference. Thank you..! |
||||
►
Sign in to add a comment |
||||
Comment 1 by dpa...@chromium.org
, Nov 30