New issue
Advanced search Search tips

Issue 910436 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Feature



Sign in to add a comment

[PIP] Add Skip Ad Functionality

Project Member Reported by steimel@chromium.org, Nov 30

Issue description

Owner: fbeaufort@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0281b1250cdec351658e9bf07dd5f5d3331ef91

commit b0281b1250cdec351658e9bf07dd5f5d3331ef91
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Sat Jan 12 10:51:54 2019

Add Skip Ad button to Picture-in-Picture window.

This CL adds 'skipad' to the Media Session actions available to web
developers. It allows them to use it to show/hide a Skip Ad button in
the Picture-in-Picture window. When users clicks it, the action handler
is called.

Screenshots: https://imgur.com/a/fxBNTKf

Change-Id: I017421e2efe9a8b31fd577647c1e2b5f73cb23f0
Bug: 910436
Reviewed-on: https://chromium-review.googlesource.com/c/1393331
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#622306}
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/ash/media/media_notification_item.cc
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/chrome/app/generated_resources.grd
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/chrome/browser/chromeos/arc/pip/arc_picture_in_picture_window_controller_impl.cc
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/chrome/browser/chromeos/arc/pip/arc_picture_in_picture_window_controller_impl.h
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/chrome/browser/picture_in_picture/DEPS
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/chrome/browser/ui/views/overlay/overlay_window_views.h
[add] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/chrome/browser/ui/views/overlay/skip_ad_label_button.cc
[add] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/chrome/browser/ui/views/overlay/skip_ad_label_button.h
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/chrome/test/data/media/picture-in-picture/window-size.html
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/chromecast/browser/cast_media_blocker_unittest.cc
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/content/browser/media/session/media_session_impl.cc
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/content/browser/media/session/media_session_impl.h
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/content/browser/media/session/media_session_impl_uma_unittest.cc
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/content/browser/media/session/media_session_uma_helper.h
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.h
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/content/browser/web_contents/web_contents_impl_unittest.cc
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/content/public/browser/media_session.h
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/content/public/browser/overlay_window.h
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/content/public/browser/picture_in_picture_window_controller.h
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/content/shell/browser/web_test/web_test_content_browser_client.cc
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/media/base/media_switches.cc
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/media/base/media_switches.h
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/services/media_session/public/cpp/test/mock_media_session.h
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/services/media_session/public/mojom/media_session.mojom
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/third_party/blink/renderer/modules/mediasession/media_session.cc
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/third_party/blink/renderer/modules/mediasession/media_session.idl
[modify] https://crrev.com/b0281b1250cdec351658e9bf07dd5f5d3331ef91/tools/metrics/histograms/enums.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b840922757246ae4721b983b47883933844c869

commit 9b840922757246ae4721b983b47883933844c869
Author: Roman Sorokin [CET] <rsorokin@chromium.org>
Date: Sat Jan 12 14:26:18 2019

Revert "Add Skip Ad button to Picture-in-Picture window."

This reverts commit b0281b1250cdec351658e9bf07dd5f5d3331ef91.

Reason for revert: Broke build (see https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/60556 )

Original change's description:
> Add Skip Ad button to Picture-in-Picture window.
> 
> This CL adds 'skipad' to the Media Session actions available to web
> developers. It allows them to use it to show/hide a Skip Ad button in
> the Picture-in-Picture window. When users clicks it, the action handler
> is called.
> 
> Screenshots: https://imgur.com/a/fxBNTKf
> 
> Change-Id: I017421e2efe9a8b31fd577647c1e2b5f73cb23f0
> Bug: 910436
> Reviewed-on: https://chromium-review.googlesource.com/c/1393331
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
> Cr-Commit-Position: refs/heads/master@{#622306}

TBR=dcheng@chromium.org,beaufort.francois@gmail.com,mlamouri@chromium.org,jochen@chromium.org,edcourtney@chromium.org,beccahughes@chromium.org

Change-Id: I2d02199072a3d8f1fc173c74ad7be4203f4506c8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 910436
Reviewed-on: https://chromium-review.googlesource.com/c/1408269
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622308}
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/ash/media/media_notification_item.cc
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/chrome/app/generated_resources.grd
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/chrome/browser/chromeos/arc/pip/arc_picture_in_picture_window_controller_impl.cc
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/chrome/browser/chromeos/arc/pip/arc_picture_in_picture_window_controller_impl.h
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/chrome/browser/picture_in_picture/DEPS
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/chrome/browser/ui/views/overlay/overlay_window_views.h
[delete] https://crrev.com/dd05131f5782853146226091e1c4d1209c47e2bb/chrome/browser/ui/views/overlay/skip_ad_label_button.cc
[delete] https://crrev.com/dd05131f5782853146226091e1c4d1209c47e2bb/chrome/browser/ui/views/overlay/skip_ad_label_button.h
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/chrome/test/data/media/picture-in-picture/window-size.html
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/chromecast/browser/cast_media_blocker_unittest.cc
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/content/browser/media/session/media_session_impl.cc
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/content/browser/media/session/media_session_impl.h
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/content/browser/media/session/media_session_impl_uma_unittest.cc
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/content/browser/media/session/media_session_uma_helper.h
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.h
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/content/browser/web_contents/web_contents_impl_unittest.cc
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/content/public/browser/media_session.h
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/content/public/browser/overlay_window.h
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/content/public/browser/picture_in_picture_window_controller.h
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/content/shell/browser/web_test/web_test_content_browser_client.cc
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/media/base/media_switches.cc
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/media/base/media_switches.h
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/services/media_session/public/cpp/test/mock_media_session.h
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/services/media_session/public/mojom/media_session.mojom
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/third_party/blink/renderer/modules/mediasession/media_session.cc
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/third_party/blink/renderer/modules/mediasession/media_session.idl
[modify] https://crrev.com/9b840922757246ae4721b983b47883933844c869/tools/metrics/histograms/enums.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc

commit a376eb709ec4f22485cb2552f4a6d46f79e8a4cc
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Mon Jan 14 10:37:46 2019

Reland "Add Skip Ad button to Picture-in-Picture window."

This is a reland of b0281b1250cdec351658e9bf07dd5f5d3331ef91

Original change's description:
> Add Skip Ad button to Picture-in-Picture window.
>
> This CL adds 'skipad' to the Media Session actions available to web
> developers. It allows them to use it to show/hide a Skip Ad button in
> the Picture-in-Picture window. When users clicks it, the action handler
> is called.
>
> Screenshots: https://imgur.com/a/fxBNTKf
>
> Change-Id: I017421e2efe9a8b31fd577647c1e2b5f73cb23f0
> Bug: 910436
> Reviewed-on: https://chromium-review.googlesource.com/c/1393331
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
> Cr-Commit-Position: refs/heads/master@{#622306}

TBR=dcheng@chromium.org

Bug: 910436
Change-Id: Id6b275daeef55552651d4272f98ff527b1d82230
Reviewed-on: https://chromium-review.googlesource.com/c/1408250
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622411}
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/ash/media/media_notification_item.cc
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/chrome/app/generated_resources.grd
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/chrome/browser/chromeos/arc/pip/arc_picture_in_picture_window_controller_impl.cc
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/chrome/browser/chromeos/arc/pip/arc_picture_in_picture_window_controller_impl.h
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/chrome/browser/picture_in_picture/DEPS
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/chrome/browser/ui/views/overlay/overlay_window_views.h
[add] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/chrome/browser/ui/views/overlay/skip_ad_label_button.cc
[add] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/chrome/browser/ui/views/overlay/skip_ad_label_button.h
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/chrome/test/data/media/picture-in-picture/window-size.html
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/chromecast/browser/cast_media_blocker_unittest.cc
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/chromeos/services/assistant/media_session/assistant_media_session.h
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/content/browser/media/session/media_session_impl.cc
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/content/browser/media/session/media_session_impl.h
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/content/browser/media/session/media_session_impl_uma_unittest.cc
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/content/browser/media/session/media_session_uma_helper.h
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.h
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/content/browser/web_contents/web_contents_impl_unittest.cc
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/content/public/browser/media_session.h
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/content/public/browser/overlay_window.h
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/content/public/browser/picture_in_picture_window_controller.h
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/content/shell/browser/web_test/web_test_content_browser_client.cc
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/media/base/media_switches.cc
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/media/base/media_switches.h
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/services/media_session/public/cpp/test/mock_media_session.h
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/services/media_session/public/mojom/media_session.mojom
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/third_party/blink/renderer/modules/mediasession/media_session.cc
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/third_party/blink/renderer/modules/mediasession/media_session.idl
[modify] https://crrev.com/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc/tools/metrics/histograms/enums.xml

Sign in to add a comment