[PIP] When video ends we should show the last frame |
||||||
Issue descriptionRight now, when a PIP'd video ends, the PIP window turns black. Instead, we want to leave the last frame visible (like what <video> elements currently do inline)
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fdfc67c27c07bcdaaa6d6b8c3fce2140e7b0f362 commit fdfc67c27c07bcdaaa6d6b8c3fce2140e7b0f362 Author: François Beaufort <beaufort.francois@gmail.com> Date: Tue Dec 04 00:15:44 2018 [Picture-in-Picture] Show last frame when video ends This PR makes sure the last video frame stays visible in the PiP window when video ends. This is what <video> elements currently do inline. Bug: 910433 Change-Id: Id6a2065146ca4c76828f3257cd3ee2af7c2eed1b Reviewed-on: https://chromium-review.googlesource.com/c/1356707 Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#613343} [modify] https://crrev.com/fdfc67c27c07bcdaaa6d6b8c3fce2140e7b0f362/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [modify] https://crrev.com/fdfc67c27c07bcdaaa6d6b8c3fce2140e7b0f362/chrome/browser/ui/views/overlay/overlay_window_views.cc [modify] https://crrev.com/fdfc67c27c07bcdaaa6d6b8c3fce2140e7b0f362/chrome/browser/ui/views/overlay/overlay_window_views.h [modify] https://crrev.com/fdfc67c27c07bcdaaa6d6b8c3fce2140e7b0f362/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc [modify] https://crrev.com/fdfc67c27c07bcdaaa6d6b8c3fce2140e7b0f362/content/public/browser/overlay_window.h
,
Dec 4
Verified in Chromium 73.0.3631.0 (developer build)
,
Dec 4
,
Dec 5
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84a3578265600799da70ff85202f69c98e09ce96 commit 84a3578265600799da70ff85202f69c98e09ce96 Author: François Beaufort <beaufort.francois@gmail.com> Date: Wed Dec 05 08:40:06 2018 [Picture-in-Picture] Show last frame when video ends This PR makes sure the last video frame stays visible in the PiP window when video ends. This is what <video> elements currently do inline. Bug: 910433 Change-Id: Id6a2065146ca4c76828f3257cd3ee2af7c2eed1b Reviewed-on: https://chromium-review.googlesource.com/c/1356707 Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613343}(cherry picked from commit fdfc67c27c07bcdaaa6d6b8c3fce2140e7b0f362) Reviewed-on: https://chromium-review.googlesource.com/c/1361709 Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/branch-heads/3626@{#67} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/84a3578265600799da70ff85202f69c98e09ce96/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [modify] https://crrev.com/84a3578265600799da70ff85202f69c98e09ce96/chrome/browser/ui/views/overlay/overlay_window_views.cc [modify] https://crrev.com/84a3578265600799da70ff85202f69c98e09ce96/chrome/browser/ui/views/overlay/overlay_window_views.h [modify] https://crrev.com/84a3578265600799da70ff85202f69c98e09ce96/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc [modify] https://crrev.com/84a3578265600799da70ff85202f69c98e09ce96/content/public/browser/overlay_window.h
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84a3578265600799da70ff85202f69c98e09ce96 Commit: 84a3578265600799da70ff85202f69c98e09ce96 Author: beaufort.francois@gmail.com Commiter: beaufort.francois@gmail.com Date: 2018-12-05 08:40:06 +0000 UTC [Picture-in-Picture] Show last frame when video ends This PR makes sure the last video frame stays visible in the PiP window when video ends. This is what <video> elements currently do inline. Bug: 910433 Change-Id: Id6a2065146ca4c76828f3257cd3ee2af7c2eed1b Reviewed-on: https://chromium-review.googlesource.com/c/1356707 Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613343}(cherry picked from commit fdfc67c27c07bcdaaa6d6b8c3fce2140e7b0f362) Reviewed-on: https://chromium-review.googlesource.com/c/1361709 Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/branch-heads/3626@{#67} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by fbeaufort@chromium.org
, Nov 30Owner: fbeaufort@chromium.org
Status: Started (was: Assigned)