page_set should not be needed in initializer for a page |
|
Issue descriptionThis is both confusing and painful to use. if a page really needs a page_set reference, then we should be able to add it in StorySet's AddStory method. It would just be great to not have it in the initializer.
,
Nov 30
Could we just move it to not be in the initializer? I guess that would have the issue of if someone added a single page object to multiple page sets then we would end up with the single page instance having only a reference to the pageset that it was most recently added to. :(
,
Nov 30
Note for posterity that this idea was inspired by the hoops that I needed to jump through for https://chromium-review.googlesource.com/c/chromium/src/+/1356320
,
Nov 30
When I looked at this problem back then, the fix I come up with is to remove the need of the map from page to wpr recording. Instead, every page instance must specify the location of their wpr record.
,
Nov 30
That solution makes sense to me. |
|
►
Sign in to add a comment |
|
Comment 1 by nedngu...@google.com
, Nov 30