New issue
Advanced search Search tips

Issue 910409 link

Starred by 1 user
Status: Fixed
Owner:
wzang@chromium.org
Closed: Dec 4
Cc:
xiy...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 883029



Sign in to add a comment

wallpaper_resizer.cc hogs CPU and cause chrome to fail liveness check

Project Member Reported by xiy...@chromium.org, Nov 29 
Example crash:
http://crash/b10b485c9b9b6f7d

chrome.txt has "top" output when chrome gets killed, which uses 106.2% CPU. And threads shows it is busy resizing the wallpaper.

The resizing task has USER_BLOCKING priority. It seems making chrome super busy and causing UI thread to not responsive. We should consider lower it to USER_VISIBLE (or even BEST_EFFORT).

And I wonder whether it makes sense to defer it a big after immediate sign-in, when there are many tasks running.

Comment 1 by wzang@chromium.org, Nov 30 

Thanks for the filing the bug. I think we can change it to USER_VISIBLE.

I think BEST_EFFORT might be too low because users will expect to see the wallpaper change soon after they select a new wallpaper. (Might also use different priorities when showing newly-selected wallpaper vs. showing existing one, but it may not be necessary.)

In addition, wallpaper resizing does not happen after sign-in (expect for the browser restart case), because we continue using the already-resized wallpaper from login screen. The wallpaper changes from blurred to unblurred, but it doesn't involve resizing.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4c77a952469bba2a71a17bb08a738cb84bab41a

commit b4c77a952469bba2a71a17bb08a738cb84bab41a
Author: Wenzhao Zang <wzang@chromium.org>
Date: Fri Nov 30 17:53:28 2018

cros: Lower the priority for wallpaper controller task runner

Bug:  910409 
Change-Id: I7c9a65ccb5e6eb11e2e3f600cef3ba13fe37ee82
Reviewed-on: https://chromium-review.googlesource.com/c/1356240
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612692}
[modify] https://crrev.com/b4c77a952469bba2a71a17bb08a738cb84bab41a/ash/wallpaper/wallpaper_controller.cc

Comment 3 by wzang@chromium.org, Dec 4

Status: Fixed (was: Untriaged)
►

Sign in to add a comment