New issue
Advanced search Search tips

Issue 910404 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 4
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Make media capabilities DB window size and expiry configurable via Finch

Project Member Reported by chcunningham@chromium.org, Nov 29

Issue description

Currently hard coded. Would be good to experiment. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2cc7586a3a924874f6f34de1473ff6eb27e5512

commit d2cc7586a3a924874f6f34de1473ff6eb27e5512
Author: chcunningham <chcunningham@chromium.org>
Date: Fri Nov 30 01:03:57 2018

MediaCapabilities: make DB configurable via Finch.

Adds flags for configuring the size of the rolling window and the number
of days to keep stats before expiring.

Bug:  910404 
Test: new unit tests
Change-Id: I8a88a81154c710a1cc9b029e2b8ef8af61d945e0
Reviewed-on: https://chromium-review.googlesource.com/c/1355996
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612479}
[modify] https://crrev.com/d2cc7586a3a924874f6f34de1473ff6eb27e5512/media/capabilities/video_decode_stats_db_impl.cc
[modify] https://crrev.com/d2cc7586a3a924874f6f34de1473ff6eb27e5512/media/capabilities/video_decode_stats_db_impl.h
[modify] https://crrev.com/d2cc7586a3a924874f6f34de1473ff6eb27e5512/media/capabilities/video_decode_stats_db_unittest.cc

NextAction: 2018-12-04
Missed branch - setting reminder to merge back after we hit canary.
Labels: Merge-Request-72
NextAction: ----
Released in Canary. Requesting merge to 72.
Pls apply appropriate OSs label.
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Project Member

Comment 6 by sheriffbot@chromium.org, Dec 4

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls merge your change to M72 branch 3626 ASAP so we can pick it up for tomororw's dev release. Thank you.
Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 4

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22e28379de88468f20cdc9564226d4aced563453

commit 22e28379de88468f20cdc9564226d4aced563453
Author: chcunningham <chcunningham@chromium.org>
Date: Tue Dec 04 19:44:28 2018

[M72] MediaCapabilities: make DB configurable via Finch.

Adds flags for configuring the size of the rolling window and the number
of days to keep stats before expiring.

Bug:  910404 
Test: new unit tests
Change-Id: I8a88a81154c710a1cc9b029e2b8ef8af61d945e0
Reviewed-on: https://chromium-review.googlesource.com/c/1355996
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612479}(cherry picked from commit d2cc7586a3a924874f6f34de1473ff6eb27e5512)
Reviewed-on: https://chromium-review.googlesource.com/c/1361631
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#40}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/22e28379de88468f20cdc9564226d4aced563453/media/capabilities/video_decode_stats_db_impl.cc
[modify] https://crrev.com/22e28379de88468f20cdc9564226d4aced563453/media/capabilities/video_decode_stats_db_impl.h
[modify] https://crrev.com/22e28379de88468f20cdc9564226d4aced563453/media/capabilities/video_decode_stats_db_unittest.cc

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/22e28379de88468f20cdc9564226d4aced563453

Commit: 22e28379de88468f20cdc9564226d4aced563453
Author: chcunningham@chromium.org
Commiter: chcunningham@chromium.org
Date: 2018-12-04 19:44:28 +0000 UTC

[M72] MediaCapabilities: make DB configurable via Finch.

Adds flags for configuring the size of the rolling window and the number
of days to keep stats before expiring.

Bug:  910404 
Test: new unit tests
Change-Id: I8a88a81154c710a1cc9b029e2b8ef8af61d945e0
Reviewed-on: https://chromium-review.googlesource.com/c/1355996
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612479}(cherry picked from commit d2cc7586a3a924874f6f34de1473ff6eb27e5512)
Reviewed-on: https://chromium-review.googlesource.com/c/1361631
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#40}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment