New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 910399 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 21 days ago
Closed: Dec 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

When clicking on a category from the NTP, ESP does not always scroll to the right position

Project Member Reported by chili@chromium.org, Nov 29

Issue description

Try:
- restart chrome
- tap on 3rd category
- observe

Try 2:
- restart chrome
- tap on 'more'
- observe

More is consistently not working, whereas the 3rd category is more inconsistent.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95f6901bfb2ee15285d4cc71356905b6c43d9b2e

commit 95f6901bfb2ee15285d4cc71356905b6c43d9b2e
Author: Cathy Li <chili@chromium.org>
Date: Tue Dec 04 00:59:41 2018

[Explore sites]: Fix scrolling issue, where clicking on NTP tiles would sometimes not scroll to the right category on the ESP.

Bug:  910399 
Change-Id: Icd9e7cc3a4974d18960458bf633c10df659f968c
Reviewed-on: https://chromium-review.googlesource.com/c/1359512
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613365}
[modify] https://crrev.com/95f6901bfb2ee15285d4cc71356905b6c43d9b2e/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java

Labels: Merge-Approved-72
Labels: -Merge-Approved-72 Merge-Request-72
Status: Fixed (was: Assigned)
Project Member

Comment 5 by sheriffbot@chromium.org, Dec 5

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls merge your change to M72 branch 3626 ASAP so we can pick it up for tomororw's dev release. Thank you.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 5

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22a9b38a58c979e4a5387f1acf3d28684be19002

commit 22a9b38a58c979e4a5387f1acf3d28684be19002
Author: Cathy Li <chili@chromium.org>
Date: Wed Dec 05 06:00:53 2018

[Explore sites]: Fix scrolling issue, where clicking on NTP tiles would sometimes not scroll to the right category on the ESP.

Bug:  910399 
Change-Id: Icd9e7cc3a4974d18960458bf633c10df659f968c
Reviewed-on: https://chromium-review.googlesource.com/c/1359512
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613365}(cherry picked from commit 95f6901bfb2ee15285d4cc71356905b6c43d9b2e)
Reviewed-on: https://chromium-review.googlesource.com/c/1362488
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#66}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/22a9b38a58c979e4a5387f1acf3d28684be19002/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/22a9b38a58c979e4a5387f1acf3d28684be19002

Commit: 22a9b38a58c979e4a5387f1acf3d28684be19002
Author: chili@chromium.org
Commiter: chili@chromium.org
Date: 2018-12-05 06:00:53 +0000 UTC

[Explore sites]: Fix scrolling issue, where clicking on NTP tiles would sometimes not scroll to the right category on the ESP.

Bug:  910399 
Change-Id: Icd9e7cc3a4974d18960458bf633c10df659f968c
Reviewed-on: https://chromium-review.googlesource.com/c/1359512
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613365}(cherry picked from commit 95f6901bfb2ee15285d4cc71356905b6c43d9b2e)
Reviewed-on: https://chromium-review.googlesource.com/c/1362488
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#66}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment