Implement USS for SendTabToSelf Proto An Eng tracking bug for go/selfshare (Issue 898256).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fe36f501d2fde7609837a457b9e3adf7d0813de commit 7fe36f501d2fde7609837a457b9e3adf7d0813de Author: Jeffrey Cohen <jeffreycohen@chromium.org> Date: Wed Dec 12 01:38:21 2018 Building out a Sync Component for Send Tab To Self. Send Tab to Self is an experimental feature to send Tabs to external devices logged in with the same Gaia ID. These files are loosely based on the reading list sync component, this first CL has stubbed out c files in order to avoid bloating the CL past being easily reviewed. Bug: 910390 Change-Id: I655d40757c43eab0fcf17b618fe8c754cad19b97 Reviewed-on: https://chromium-review.googlesource.com/c/1312991 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by: Cait Phillips <caitkp@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615754} [modify] https://crrev.com/7fe36f501d2fde7609837a457b9e3adf7d0813de/WATCHLISTS [modify] https://crrev.com/7fe36f501d2fde7609837a457b9e3adf7d0813de/chrome/browser/BUILD.gn [add] https://crrev.com/7fe36f501d2fde7609837a457b9e3adf7d0813de/components/send_tab_to_self/BUILD.gn [add] https://crrev.com/7fe36f501d2fde7609837a457b9e3adf7d0813de/components/send_tab_to_self/DEPS [add] https://crrev.com/7fe36f501d2fde7609837a457b9e3adf7d0813de/components/send_tab_to_self/OWNERS [add] https://crrev.com/7fe36f501d2fde7609837a457b9e3adf7d0813de/components/send_tab_to_self/README.md [add] https://crrev.com/7fe36f501d2fde7609837a457b9e3adf7d0813de/components/send_tab_to_self/send_tab_to_self_bridge.cc [add] https://crrev.com/7fe36f501d2fde7609837a457b9e3adf7d0813de/components/send_tab_to_self/send_tab_to_self_bridge.h [add] https://crrev.com/7fe36f501d2fde7609837a457b9e3adf7d0813de/components/send_tab_to_self/send_tab_to_self_entry.cc [add] https://crrev.com/7fe36f501d2fde7609837a457b9e3adf7d0813de/components/send_tab_to_self/send_tab_to_self_entry.h [add] https://crrev.com/7fe36f501d2fde7609837a457b9e3adf7d0813de/components/send_tab_to_self/send_tab_to_self_model.cc [add] https://crrev.com/7fe36f501d2fde7609837a457b9e3adf7d0813de/components/send_tab_to_self/send_tab_to_self_model.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/292508f043f0cccc34333e49668549514fc51585 commit 292508f043f0cccc34333e49668549514fc51585 Author: Jeffrey Cohen <jeffreycohen@chromium.org> Date: Wed Dec 12 19:42:23 2018 Remove device from send_tab_to_self proto The device ID and Name are not wanted for the send tab workflow Bug: 910390 Change-Id: I27a4808366a38cd91283c76a0b361d61216b3fde Reviewed-on: https://chromium-review.googlesource.com/c/1372537 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#616000} [modify] https://crrev.com/292508f043f0cccc34333e49668549514fc51585/components/sync/protocol/proto_visitors.h [modify] https://crrev.com/292508f043f0cccc34333e49668549514fc51585/components/sync/protocol/send_tab_to_self_specifics.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eaca19bda5e0ba755045cb69de0f8c90238f54da commit eaca19bda5e0ba755045cb69de0f8c90238f54da Author: Jeffrey Cohen <jeffreycohen@chromium.org> Date: Tue Dec 18 17:59:45 2018 Adding back the device name to the SendTabToSelf sync proto based on the latest XD mocks we would like to try to include the originating foreign device name in the notification, to help remind the user for the context on why they're seeing that notification Bug: 910390 Change-Id: If63d787b410bb4377e97517311b854ef12437db9 Reviewed-on: https://chromium-review.googlesource.com/c/1377209 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#617557} [modify] https://crrev.com/eaca19bda5e0ba755045cb69de0f8c90238f54da/components/sync/protocol/proto_visitors.h [modify] https://crrev.com/eaca19bda5e0ba755045cb69de0f8c90238f54da/components/sync/protocol/send_tab_to_self_specifics.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d7c60742d6721edc0362eb3405ceae15e79b12b commit 7d7c60742d6721edc0362eb3405ceae15e79b12b Author: Jeffrey Cohen <jeffreycohen@chromium.org> Date: Tue Jan 08 19:01:15 2019 [Send Tab To Self] adding a navigation time to proto. This new field in the proto will allow better integration with the history infrastructure and also serve as a unique identifier for each share entry. Bug: 910390 Change-Id: I7086dde44ea5549b4ff1e0b91355bea3e0074762 Reviewed-on: https://chromium-review.googlesource.com/c/1400954 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#620822} [modify] https://crrev.com/7d7c60742d6721edc0362eb3405ceae15e79b12b/components/sync/protocol/proto_visitors.h [modify] https://crrev.com/7d7c60742d6721edc0362eb3405ceae15e79b12b/components/sync/protocol/send_tab_to_self_specifics.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4fc4abb4a11701aeee38389be1d1da0c855ebdb5 commit 4fc4abb4a11701aeee38389be1d1da0c855ebdb5 Author: Jeffrey Cohen <jeffreycohen@chromium.org> Date: Mon Jan 14 20:36:01 2019 Implementation of USS sync backend for Send Tab to Device feature Bug: 910390 Change-Id: I7a48e07bceadcf000299b3e12f85dc8d6f8d5599 Reviewed-on: https://chromium-review.googlesource.com/c/1391741 Reviewed-by: Cait Phillips <caitkp@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#622584} [modify] https://crrev.com/4fc4abb4a11701aeee38389be1d1da0c855ebdb5/components/BUILD.gn [modify] https://crrev.com/4fc4abb4a11701aeee38389be1d1da0c855ebdb5/components/send_tab_to_self/BUILD.gn [modify] https://crrev.com/4fc4abb4a11701aeee38389be1d1da0c855ebdb5/components/send_tab_to_self/send_tab_to_self_bridge.cc [modify] https://crrev.com/4fc4abb4a11701aeee38389be1d1da0c855ebdb5/components/send_tab_to_self/send_tab_to_self_bridge.h [add] https://crrev.com/4fc4abb4a11701aeee38389be1d1da0c855ebdb5/components/send_tab_to_self/send_tab_to_self_bridge_unittest.cc [modify] https://crrev.com/4fc4abb4a11701aeee38389be1d1da0c855ebdb5/components/send_tab_to_self/send_tab_to_self_entry.cc [modify] https://crrev.com/4fc4abb4a11701aeee38389be1d1da0c855ebdb5/components/send_tab_to_self/send_tab_to_self_entry.h [add] https://crrev.com/4fc4abb4a11701aeee38389be1d1da0c855ebdb5/components/send_tab_to_self/send_tab_to_self_entry_unittest.cc [modify] https://crrev.com/4fc4abb4a11701aeee38389be1d1da0c855ebdb5/components/send_tab_to_self/send_tab_to_self_model.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/566c3ff72ca5a64ca3cbc9ef4842dcf32aa6450a commit 566c3ff72ca5a64ca3cbc9ef4842dcf32aa6450a Author: Jeffrey Cohen <jeffreycohen@chromium.org> Date: Thu Jan 17 16:04:55 2019 [SendTabToSelf] adding infrastructure for observers and notifications for Send Tab To Self This change does not have the Bridge calling to notify these observers. also add deletion case. Bug: 910390 Change-Id: I8b29af5b05c2de9cd1cf318127e974e1505376b6 Reviewed-on: https://chromium-review.googlesource.com/c/1413655 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#623698} [modify] https://crrev.com/566c3ff72ca5a64ca3cbc9ef4842dcf32aa6450a/components/send_tab_to_self/BUILD.gn [modify] https://crrev.com/566c3ff72ca5a64ca3cbc9ef4842dcf32aa6450a/components/send_tab_to_self/send_tab_to_self_bridge.cc [modify] https://crrev.com/566c3ff72ca5a64ca3cbc9ef4842dcf32aa6450a/components/send_tab_to_self/send_tab_to_self_bridge.h [modify] https://crrev.com/566c3ff72ca5a64ca3cbc9ef4842dcf32aa6450a/components/send_tab_to_self/send_tab_to_self_bridge_unittest.cc [modify] https://crrev.com/566c3ff72ca5a64ca3cbc9ef4842dcf32aa6450a/components/send_tab_to_self/send_tab_to_self_model.cc [modify] https://crrev.com/566c3ff72ca5a64ca3cbc9ef4842dcf32aa6450a/components/send_tab_to_self/send_tab_to_self_model.h [add] https://crrev.com/566c3ff72ca5a64ca3cbc9ef4842dcf32aa6450a/components/send_tab_to_self/send_tab_to_self_model_observer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a89b1158d5ea6ea7c7183ca64dba58b973ba45dd commit a89b1158d5ea6ea7c7183ca64dba58b973ba45dd Author: Jeffrey Cohen <jeffreycohen@chromium.org> Date: Fri Jan 18 17:25:59 2019 [SendTabToSelf] Add a keyed service to SendTabToSelf SendTabToSelf Service provides an API for interfacing with the SendTabToSelfModel Bug: 910390 Change-Id: Idef5bfa907b5252ca8d6bede2f903eb6aa736f76 Reviewed-on: https://chromium-review.googlesource.com/c/1415762 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#624177} [modify] https://crrev.com/a89b1158d5ea6ea7c7183ca64dba58b973ba45dd/components/send_tab_to_self/BUILD.gn [modify] https://crrev.com/a89b1158d5ea6ea7c7183ca64dba58b973ba45dd/components/send_tab_to_self/DEPS [add] https://crrev.com/a89b1158d5ea6ea7c7183ca64dba58b973ba45dd/components/send_tab_to_self/send_tab_to_self_service.cc [add] https://crrev.com/a89b1158d5ea6ea7c7183ca64dba58b973ba45dd/components/send_tab_to_self/send_tab_to_self_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85a5ea994d5940f907bf9288bce8da9ac1a768f4 commit 85a5ea994d5940f907bf9288bce8da9ac1a768f4 Author: Jeffrey Cohen <jeffreycohen@chromium.org> Date: Tue Jan 22 18:18:13 2019 [SendTabToSelf] Add Service Factory to create a SendTabToSelfService Bug: 910390 Change-Id: Ife8c01e8b71637b0d0a1fcf10e16fd2aac1d31a5 Reviewed-on: https://chromium-review.googlesource.com/c/1422501 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#624837} [modify] https://crrev.com/85a5ea994d5940f907bf9288bce8da9ac1a768f4/chrome/browser/BUILD.gn [add] https://crrev.com/85a5ea994d5940f907bf9288bce8da9ac1a768f4/chrome/browser/sync/send_tab_to_self_sync_service_factory.cc [add] https://crrev.com/85a5ea994d5940f907bf9288bce8da9ac1a768f4/chrome/browser/sync/send_tab_to_self_sync_service_factory.h
Comment 1 by bugdroid1@chromium.org
, Dec 12