Browser crashes after searching with search box, closing and then re-opening |
||||||||||||
Issue descriptionChrome Version: 72.0.3625.0 What steps will reproduce the problem? (1)Open launcher to full screen (2)Search "weather" in search box (3)Wait for weather result, then hit enter or close launcher (4)Open launcher to full screen, then browser crashes. What is the expected result? Launcher opens without browser crashing What happens instead? Browser crashes
,
Nov 29
,
Nov 30
Do we really want this to hold dev? How often do we expect users to use this functionality on the dev channel?
,
Nov 30
Searching with the launcher is one of the primary ways users launch apps. Happy to remove RBD though.
,
Dec 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59f9c8568ddd6937fe2db1adbd9813354b0f69e4 commit 59f9c8568ddd6937fe2db1adbd9813354b0f69e4 Author: Matthew Mourgos <mmourgos@chromium.org> Date: Sat Dec 01 23:56:29 2018 Add check for search_result_ pointer to prevent browser crash Fixes browser crash after search result answer card search Bug: 910388 Change-Id: I7ab881d2cf4da2920439be73da2977a7c436b6af Reviewed-on: https://chromium-review.googlesource.com/c/1356715 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Weidong Guo <weidongg@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#612954} [modify] https://crrev.com/59f9c8568ddd6937fe2db1adbd9813354b0f69e4/ash/app_list/views/search_result_answer_card_view.cc
,
Dec 3
Branch was at 612437, so lets merge this.
,
Dec 3
Bulk moving <p-1's to the next milestone because we branched to M-73.
,
Dec 3
(didn't mean to grab these P-1's)
,
Dec 4
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4dbdb4319b7fc1282d0476515680c7c9265648f commit b4dbdb4319b7fc1282d0476515680c7c9265648f Author: Matthew Mourgos <mmourgos@chromium.org> Date: Tue Dec 04 19:28:39 2018 Add check for search_result_ pointer to prevent browser crash Fixes browser crash after search result answer card search Bug: 910388 Change-Id: I7ab881d2cf4da2920439be73da2977a7c436b6af Reviewed-on: https://chromium-review.googlesource.com/c/1356715 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Weidong Guo <weidongg@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612954}(cherry picked from commit 59f9c8568ddd6937fe2db1adbd9813354b0f69e4) Reviewed-on: https://chromium-review.googlesource.com/c/1358926 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/branch-heads/3625@{#4} Cr-Branched-From: 1c2052ab5f930300f4a5fe2cc1de15a06c64e516-refs/heads/master@{#611977} [modify] https://crrev.com/b4dbdb4319b7fc1282d0476515680c7c9265648f/ash/app_list/views/search_result_answer_card_view.cc
,
Dec 4
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47005b2b2796ece05937dcbe4ba7119bb71c4b2b commit 47005b2b2796ece05937dcbe4ba7119bb71c4b2b Author: Matthew Mourgos <mmourgos@chromium.org> Date: Wed Dec 19 22:06:43 2018 Add check for search_result_ pointer to prevent browser crash Fixes browser crash after search result answer card search Bug: 910388 Change-Id: I7ab881d2cf4da2920439be73da2977a7c436b6af Reviewed-on: https://chromium-review.googlesource.com/c/1356715 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Weidong Guo <weidongg@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612954}(cherry picked from commit 59f9c8568ddd6937fe2db1adbd9813354b0f69e4) Reviewed-on: https://chromium-review.googlesource.com/c/1385109 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#474} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/47005b2b2796ece05937dcbe4ba7119bb71c4b2b/ash/app_list/views/search_result_answer_card_view.cc
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47005b2b2796ece05937dcbe4ba7119bb71c4b2b Commit: 47005b2b2796ece05937dcbe4ba7119bb71c4b2b Author: mmourgos@chromium.org Commiter: newcomer@chromium.org Date: 2018-12-19 22:06:43 +0000 UTC Add check for search_result_ pointer to prevent browser crash Fixes browser crash after search result answer card search Bug: 910388 Change-Id: I7ab881d2cf4da2920439be73da2977a7c436b6af Reviewed-on: https://chromium-review.googlesource.com/c/1356715 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Weidong Guo <weidongg@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612954}(cherry picked from commit 59f9c8568ddd6937fe2db1adbd9813354b0f69e4) Reviewed-on: https://chromium-review.googlesource.com/c/1385109 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#474} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by mmourgos@chromium.org
, Nov 29Status: Assigned (was: Untriaged)