ios-slimnav is failing on iPhone X 11.4/12.1 |
|||||
Issue descriptionSince https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-slimnav/465 ios_chrome_web_egtests's testChildTabOrdering ios_chrome_integration_egtests's ContextMenuTestCase/testContextMenuSelectedTextCallout are failing.
,
Nov 29
Suspecting ios-related CLs: https://chromium-review.googlesource.com/c/chromium/src/+/1355179 https://chromium-review.googlesource.com/c/chromium/src/+/1352958 https://chromium-review.googlesource.com/c/chromium/src/+/1354414 https://chromium-review.googlesource.com/c/chromium/src/+/1354329 Adding authors as CC; any idea?
,
Nov 29
,
Nov 29
I'm bisecting culprit. Will update the bug soon.
,
Nov 29
Justin, it looks like b2432bbba3c089f0f4c117d6a7e57914a49249fb is a culprit.
,
Nov 30
Thanks, Eugene! Can/should we revert the culprit CL? (Deferring to APAC sheriffs)
,
Nov 30
I'm investigating!
,
Nov 30
Any updates? ios-slimnav still fails.
,
Nov 30
Fix here: crrev.com/c/1356034
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51a04f82f31aa29ebbb2d3c3e8de6c350dac6179 commit 51a04f82f31aa29ebbb2d3c3e8de6c350dac6179 Author: Justin Cohen <justincohen@google.com> Date: Fri Nov 30 05:14:59 2018 [ios] Center long press WKebView links for egtests. EarlGrey doesn't natively support tapping on links within WKWebView, and the long press implementation hack used doesn't work well with links near the edge of the page when allowsBackForwardNavigationGestures is enabled. As this is a test only issue, a simple fix is to just center the items being long pressed. Tbr: eugenebut Bug: 910375 Change-Id: Ibb7079b22e1ce1d8baa52f0205be038dfec9d2c4 Reviewed-on: https://chromium-review.googlesource.com/c/1356034 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#612571} [modify] https://crrev.com/51a04f82f31aa29ebbb2d3c3e8de6c350dac6179/ios/chrome/browser/context_menu/context_menu_egtest.mm [modify] https://crrev.com/51a04f82f31aa29ebbb2d3c3e8de6c350dac6179/ios/testing/data/http_server_files/links.html
,
Nov 30
The bot is green as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-slimnav/477. Thanks for the fix. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by hirosh...@chromium.org
, Nov 29