New issue
Advanced search Search tips

Issue 910375 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 30
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

ios-slimnav is failing on iPhone X 11.4/12.1

Project Member Reported by hirosh...@chromium.org, Nov 29

Issue description

Since
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-slimnav/465

ios_chrome_web_egtests's testChildTabOrdering
ios_chrome_integration_egtests's ContextMenuTestCase/testContextMenuSelectedTextCallout

are failing.

 
Only on
- iPhone X iOS 11.4
- iPhone X iOS 12.1

Labels: -Pri-3 Pri-1
Summary: ios-slimnav is failing on iPhone X 11.4/12.1 (was: ios-slimnav is failing)
I'm bisecting culprit. Will update the bug soon.
Owner: justincohen@chromium.org
Status: Assigned (was: Started)
Justin, it looks like b2432bbba3c089f0f4c117d6a7e57914a49249fb is a culprit.
Thanks, Eugene!

Can/should we revert the culprit CL?
(Deferring to APAC sheriffs)
I'm investigating!
Any updates? ios-slimnav still fails.
Fix here: crrev.com/c/1356034
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51a04f82f31aa29ebbb2d3c3e8de6c350dac6179

commit 51a04f82f31aa29ebbb2d3c3e8de6c350dac6179
Author: Justin Cohen <justincohen@google.com>
Date: Fri Nov 30 05:14:59 2018

[ios] Center long press WKebView links for egtests.

EarlGrey doesn't natively support tapping on links within WKWebView, and the
long press implementation hack used doesn't work well with links near the edge
of the page when allowsBackForwardNavigationGestures is enabled.  As this is a
test only issue, a simple fix is to just center the items being long pressed.

Tbr: eugenebut
Bug:  910375 
Change-Id: Ibb7079b22e1ce1d8baa52f0205be038dfec9d2c4
Reviewed-on: https://chromium-review.googlesource.com/c/1356034
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612571}
[modify] https://crrev.com/51a04f82f31aa29ebbb2d3c3e8de6c350dac6179/ios/chrome/browser/context_menu/context_menu_egtest.mm
[modify] https://crrev.com/51a04f82f31aa29ebbb2d3c3e8de6c350dac6179/ios/testing/data/http_server_files/links.html

Status: Fixed (was: Assigned)
The bot is green as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-slimnav/477. Thanks for the fix.

Sign in to add a comment