New issue
Advanced search Search tips

Issue 910372 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Add metric to record parsed forms by type (address / cc)

Project Member Reported by se...@chromium.org, Nov 29

Issue description

We have a metric for form interactions but not for form parsing.

Having this will help us size up the opportunity.
 
Labels: Merge-Request-72
Status: Verified (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 12

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 12

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5066b043201302f79c755715834f55aed8b923a

commit d5066b043201302f79c755715834f55aed8b923a
Author: sebsg <sebsg@chromium.org>
Date: Wed Dec 12 20:24:07 2018

Merge-72 [AF] Add metric to record parsed forms by type (address / cc)

TBR=sebsg@chromium.org

(cherry picked from commit 7948a399469304b2d85a88e35bc1e2aa84f946ad)

Bug:  910372 
Change-Id: Ic0859c1fab02010f22664d0138d6e3516012545f
Reviewed-on: https://chromium-review.googlesource.com/c/1358649
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615549}
Reviewed-on: https://chromium-review.googlesource.com/c/1374570
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#302}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/d5066b043201302f79c755715834f55aed8b923a/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/d5066b043201302f79c755715834f55aed8b923a/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/d5066b043201302f79c755715834f55aed8b923a/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/d5066b043201302f79c755715834f55aed8b923a/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/d5066b043201302f79c755715834f55aed8b923a/tools/metrics/actions/actions.xml
[modify] https://crrev.com/d5066b043201302f79c755715834f55aed8b923a/tools/metrics/histograms/enums.xml

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/d5066b043201302f79c755715834f55aed8b923a

Commit: d5066b043201302f79c755715834f55aed8b923a
Author: sebsg@chromium.org
Commiter: sebsg@chromium.org
Date: 2018-12-12 20:24:07 +0000 UTC

Merge-72 [AF] Add metric to record parsed forms by type (address / cc)

TBR=sebsg@chromium.org

(cherry picked from commit 7948a399469304b2d85a88e35bc1e2aa84f946ad)

Bug:  910372 
Change-Id: Ic0859c1fab02010f22664d0138d6e3516012545f
Reviewed-on: https://chromium-review.googlesource.com/c/1358649
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615549}
Reviewed-on: https://chromium-review.googlesource.com/c/1374570
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#302}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment