New issue
Advanced search Search tips

Issue 910356 link

Starred by 1 user
Status: Fixed
Owner:
collinbaker@chromium.org
Closed: Jan 17
Cc:
cyflee@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocking:
issue 910354



Sign in to add a comment

Set up metrics/histogram for IPH pilot

Project Member Reported by cyflee@chromium.org, Nov 29 
Add a histogram to track IPH interaction:Reopened close tab, proposed options:
IPH shown
IPH bubble clicked (in theory nothing should happen right? but good to record if people actually click on the bubble) 
IPH dismissed_time out
Step 1: Menu button clicked
Step 2: History button clicked
Step 3: Recently closed tab clicked

Comment 1 by cyflee@chromium.org, Nov 29

Cc: cyflee@chromium.org
Owner: collinbaker@chromium.org

Comment 2 by collinbaker@chromium.org, Nov 29

Status: Assigned (was: Untriaged)

Comment 3 by cyflee@chromium.org, Jan 10 

reminder to add back the "IPH bubble clicked" option
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 17 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1082d33dd3ac8dd8d25649f878fd345069028607

commit 1082d33dd3ac8dd8d25649f878fd345069028607
Author: Collin Baker <collinbaker@chromium.org>
Date: Thu Jan 17 00:58:18 2019

Log action and don't close when user clicks in-product help bubble

Bug:  910356 
Change-Id: Ifa766051089ab2e0f648bc05f185ba4c6138c0c1
Reviewed-on: https://chromium-review.googlesource.com/c/1410502
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623481}
[modify] https://crrev.com/1082d33dd3ac8dd8d25649f878fd345069028607/chrome/browser/ui/views/feature_promos/feature_promo_bubble_view.cc
[modify] https://crrev.com/1082d33dd3ac8dd8d25649f878fd345069028607/tools/metrics/actions/actions.xml
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 17 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1741332b9a44460cb2f9cab2d8a5c0ff6aecc880

commit 1741332b9a44460cb2f9cab2d8a5c0ff6aecc880
Author: Collin Baker <collinbaker@chromium.org>
Date: Thu Jan 17 01:23:14 2019

Add histogram to track how far user followed reopen tab IPH promo

This adds UMA logging for the last step of reopen tab IPH a user
completed. This also adds a new OnExecuteCommand method to
AppMenuObserver which is necessary for ReopenTabPromoController to
determine whether IPH was completed successfully.

Bug:  910356 
Change-Id: I8280198b285324f12d10f31d334632fbad77b66b
Reviewed-on: https://chromium-review.googlesource.com/c/1391423
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623499}
[modify] https://crrev.com/1741332b9a44460cb2f9cab2d8a5c0ff6aecc880/chrome/browser/ui/views/feature_promos/reopen_tab_promo_controller.cc
[modify] https://crrev.com/1741332b9a44460cb2f9cab2d8a5c0ff6aecc880/chrome/browser/ui/views/feature_promos/reopen_tab_promo_controller.h
[modify] https://crrev.com/1741332b9a44460cb2f9cab2d8a5c0ff6aecc880/chrome/browser/ui/views/toolbar/app_menu.cc
[modify] https://crrev.com/1741332b9a44460cb2f9cab2d8a5c0ff6aecc880/chrome/browser/ui/views/toolbar/app_menu_observer.h
[modify] https://crrev.com/1741332b9a44460cb2f9cab2d8a5c0ff6aecc880/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/1741332b9a44460cb2f9cab2d8a5c0ff6aecc880/tools/metrics/histograms/histograms.xml

Comment 6 by collinbaker@chromium.org, Jan 17 (5 days ago)

Status: Fixed (was: Assigned)
►

Sign in to add a comment