Launch navi Desktop IPH pilot in Canary |
|||||||
Issue descriptionto collect data from canary users to investigate: 1. If triggering logic is correct 2. If users find this userful 3. Identify false positive/false negative 4. Investigate usefulness
,
Nov 29
,
Nov 29
,
Nov 29
,
Dec 3
,
Dec 3
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2946b61511979796d459d961e687dc67b15d4c0 commit d2946b61511979796d459d961e687dc67b15d4c0 Author: Collin Baker <collinbaker@chromium.org> Date: Thu Dec 20 00:16:20 2018 Close reopen tab IPH promo bubble when app menu is opened The promo bubble doesn't automatically close when the app menu button is clicked. This causes a crash if the app menu is opened then closed before the bubble times out, since dismissal is reported to the IPH backend twice. This fixes the crash by closing the bubble manually upon menu opening. Bug: 910354 Change-Id: I35e0e5a217b12cf872910e896216500459122bef Reviewed-on: https://chromium-review.googlesource.com/c/1372446 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#618022} [modify] https://crrev.com/d2946b61511979796d459d961e687dc67b15d4c0/chrome/browser/ui/views/feature_promos/reopen_tab_promo_controller.cc
,
Jan 15
@Collin any updates here?
,
Jan 15
Still blocked on this: https://chromium-review.googlesource.com/c/chromium/src/+/1391423
,
Jan 17
(5 days ago)
It's launched now |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by cyflee@chromium.org
, Nov 29