Issue metadata
Sign in to add a comment
|
6.7%-156.5% regression in system_health.memory_desktop at 611922:611999 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Nov 29
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/1239c352140000
,
Nov 29
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/1239c352140000 gpu: Disable CCPR for OOP raster. by khushalsagar@chromium.org https://chromium.googlesource.com/chromium/src/+/193eda157bdb1c66d9afdc9c54a36e0ccc249293 memory:chrome:all_processes:reported_by_chrome:skia:effective_size: 2.327e+06 → 5.973e+06 (+3.646e+06) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: https://bit.ly/system-health-benchmarks
,
Nov 29
All that patch did was disable CCPR using GrContextOptions. We had an issue with losing some caching with CCPR, which probably lowered skia's memory usage, and since the alternate path renderer is getting that caching we are seeing a higher memory usage. Assigning to Chris for confirmation but I think this is a WontFix if its the case above.
,
Nov 30
I agree with your assessment. Also note that if animating simple paths, GrSoftwarePathRenderer renderer will *not* clean up old path masks. They will just pile up until the cache feels memory pressure. How determined are we to make Skia cache individual path masks? Tiles are already a cache in and of themselves. Maybe a second level cache isn't worth the memory? There is a context option to disable caching of path masks altogether if we want to investigate.
,
Nov 30
The caching strategy of evicting entries once you hit the cache limit, even if the entries might never be reused, is fine. Its the strategy we adopt for all other caching too. We also evict all of skia's caching on idle cleanup, so this memory wouldn't sit around forever unless there is continuous raster.
,
Jan 9
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Nov 29