New issue
Advanced search Search tips

Issue 910347 link

Starred by 1 user
Status: Fixed
Owner:
sclit...@chromium.org
Closed: Nov 30
Cc:
rajendrant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

LazyLoad: Record metrics for how often deferred images become visible before they've finished loading

Project Member Reported by sclit...@chromium.org, Nov 29 
Similar to the Blink.VisibleBeforeLoaded.LazyLoadEligibleFrames.BelowTheFold
metric that's recorded for deferred frames, it would be useful to record a corresponding metric for deferred images.

One problem with the existing VisibleLoadTime metrics is that those metrics are recorded when the content finally loads, which could ignore content that hasn't finished loading by the time the user navigates away or closes the tab. To solve this, we should record metrics for how often deferred images become visible before they've finished loading, separated by ECT.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/292f9d798371e0a0da10a6f48d2a553c73c5d8e0

commit 292f9d798371e0a0da10a6f48d2a553c73c5d8e0
Author: Scott Little <sclittle@chromium.org>
Date: Fri Nov 30 01:44:08 2018

LazyLoad: Record VisibleBeforeLoaded histograms for lazy images.

This CL records VisibleBeforeLoaded histograms when lazily loaded images
become visible before they've finished loading. This metric is useful to
look at alongside the existing VisibleLoadTime metrics, since the
VisibleLoadTime metrics aren't recorded until the image finishes
loading, which can lead to misleading data if the user navigates away or
closes the tab before the image finishes loading, particularly on slow
networks.

TBR=mpearson@chromium.org

Bug:  910347 
Change-Id: I349eb69d173420ada94e3febeaeb4e369c998e07
Reviewed-on: https://chromium-review.googlesource.com/c/1356009
Commit-Queue: Scott Little <sclittle@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612486}
[modify] https://crrev.com/292f9d798371e0a0da10a6f48d2a553c73c5d8e0/third_party/blink/renderer/core/html/lazy_load_image_observer.cc
[modify] https://crrev.com/292f9d798371e0a0da10a6f48d2a553c73c5d8e0/tools/metrics/histograms/histograms.xml

Comment 2 by sclit...@chromium.org, Nov 30

Status: Fixed (was: Started)
►

Sign in to add a comment