Printing dialog displays punycode in footer |
|||
Issue descriptionSteps to repro: - Go to http://пример.испытание/ - Right click and print The footer at the bottom left shows the punycoded URL (http://xn--e1afmkfd.xn--80akhbyknj4f/) whereas the top of the page shows unicode. The footer should use url_formatter to format the URL.
,
Nov 30
WIP CL here https://chromium-review.googlesource.com/c/chromium/src/+/1356235
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e091262948b7eee116da35f0faed9cda3a1f796a commit e091262948b7eee116da35f0faed9cda3a1f796a Author: Christopher Thompson <cthomp@chromium.org> Date: Fri Nov 30 20:55:18 2018 Format print header/footer URLs using url_formatter::FormatUrl This CL changes the print preview handler to set kSettingHeaderFooterURL using url_formatter::FormatUrl rather than extracting the GURL::spec() directly. In particular, this allows safe IDNs to be displayed as unicode rather than punycode in the header/footer (matching how they are displayed in the omnibox). Bug: 910344 Change-Id: Iabed0e1821df29e5c2a5b6fc9953fa6d8cb3e10d Reviewed-on: https://chromium-review.googlesource.com/c/1356235 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#612775} [modify] https://crrev.com/e091262948b7eee116da35f0faed9cda3a1f796a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
,
Nov 30
c#3 fixes the punycode display, but does not try to tweak elision. I think this is fine for this case -- eliding the full URL from the right seems reasonable for print job footers (and it has not security ramifications that I can think of). |
|||
►
Sign in to add a comment |
|||
Comment 1 by mea...@chromium.org
, Nov 29