New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 910323 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

make PIP accessible using shortcut key

Project Member Reported by osh...@chromium.org, Nov 29

Issue description

make PIP accessible using shortcut key.
shift-alt-p is taken for stylus (probably for *P*en).
Ben suggested v for video, so i'll go with shift-alt-v.
 
Components: UI>Accessibility Blink>Media>PictureInPicture
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7353b9bb958023704aa99fdb1f8427be0b5507f5

commit 7353b9bb958023704aa99fdb1f8427be0b5507f5
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Sat Dec 01 02:12:02 2018

Accessibility shortcuts to access PIP window

Make PIP window non activatable by default on ChromeOS.

Bug:  910323 
Test: Manual.  unittest T.B.D.
Change-Id: Ibd444a182c731c4e585c428938bbc4cc0d03d9a2
Reviewed-on: https://chromium-review.googlesource.com/c/1354410
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612905}
[modify] https://crrev.com/7353b9bb958023704aa99fdb1f8427be0b5507f5/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/7353b9bb958023704aa99fdb1f8427be0b5507f5/ash/accelerators/accelerator_table_unittest.cc
[modify] https://crrev.com/7353b9bb958023704aa99fdb1f8427be0b5507f5/ash/focus_cycler.cc
[modify] https://crrev.com/7353b9bb958023704aa99fdb1f8427be0b5507f5/ash/focus_cycler.h
[modify] https://crrev.com/7353b9bb958023704aa99fdb1f8427be0b5507f5/ash/public/cpp/accelerators.cc
[modify] https://crrev.com/7353b9bb958023704aa99fdb1f8427be0b5507f5/ash/public/cpp/accelerators.h
[modify] https://crrev.com/7353b9bb958023704aa99fdb1f8427be0b5507f5/ash/wm/mru_window_tracker.cc
[modify] https://crrev.com/7353b9bb958023704aa99fdb1f8427be0b5507f5/ash/wm/window_state.cc
[modify] https://crrev.com/7353b9bb958023704aa99fdb1f8427be0b5507f5/ash/wm/window_state.h
[modify] https://crrev.com/7353b9bb958023704aa99fdb1f8427be0b5507f5/ash/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/7353b9bb958023704aa99fdb1f8427be0b5507f5/chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_metadata_unittest.cc
[modify] https://crrev.com/7353b9bb958023704aa99fdb1f8427be0b5507f5/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/7353b9bb958023704aa99fdb1f8427be0b5507f5/tools/metrics/actions/actions.xml

Labels: Merge-Request-72
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 2

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 3

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dcb87845f9166ee3b4272ec9132a1ffa299da91

commit 9dcb87845f9166ee3b4272ec9132a1ffa299da91
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Mon Dec 03 18:17:15 2018

Accessibility shortcuts to access PIP window

Make PIP window non activatable by default on ChromeOS.

Bug:  910323 
Test: Manual.  unittest T.B.D.
Change-Id: Ibd444a182c731c4e585c428938bbc4cc0d03d9a2
Reviewed-on: https://chromium-review.googlesource.com/c/1354410
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612905}(cherry picked from commit 7353b9bb958023704aa99fdb1f8427be0b5507f5)
Reviewed-on: https://chromium-review.googlesource.com/c/1358920
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#10}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/9dcb87845f9166ee3b4272ec9132a1ffa299da91/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/9dcb87845f9166ee3b4272ec9132a1ffa299da91/ash/accelerators/accelerator_table_unittest.cc
[modify] https://crrev.com/9dcb87845f9166ee3b4272ec9132a1ffa299da91/ash/focus_cycler.cc
[modify] https://crrev.com/9dcb87845f9166ee3b4272ec9132a1ffa299da91/ash/focus_cycler.h
[modify] https://crrev.com/9dcb87845f9166ee3b4272ec9132a1ffa299da91/ash/public/cpp/accelerators.cc
[modify] https://crrev.com/9dcb87845f9166ee3b4272ec9132a1ffa299da91/ash/public/cpp/accelerators.h
[modify] https://crrev.com/9dcb87845f9166ee3b4272ec9132a1ffa299da91/ash/wm/mru_window_tracker.cc
[modify] https://crrev.com/9dcb87845f9166ee3b4272ec9132a1ffa299da91/ash/wm/window_state.cc
[modify] https://crrev.com/9dcb87845f9166ee3b4272ec9132a1ffa299da91/ash/wm/window_state.h
[modify] https://crrev.com/9dcb87845f9166ee3b4272ec9132a1ffa299da91/ash/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/9dcb87845f9166ee3b4272ec9132a1ffa299da91/chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_metadata_unittest.cc
[modify] https://crrev.com/9dcb87845f9166ee3b4272ec9132a1ffa299da91/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/9dcb87845f9166ee3b4272ec9132a1ffa299da91/tools/metrics/actions/actions.xml

Status: Fixed (was: Started)
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/9dcb87845f9166ee3b4272ec9132a1ffa299da91

Commit: 9dcb87845f9166ee3b4272ec9132a1ffa299da91
Author: oshima@chromium.org
Commiter: oshima@chromium.org
Date: 2018-12-03 18:17:15 +0000 UTC

Accessibility shortcuts to access PIP window

Make PIP window non activatable by default on ChromeOS.

Bug:  910323 
Test: Manual.  unittest T.B.D.
Change-Id: Ibd444a182c731c4e585c428938bbc4cc0d03d9a2
Reviewed-on: https://chromium-review.googlesource.com/c/1354410
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612905}(cherry picked from commit 7353b9bb958023704aa99fdb1f8427be0b5507f5)
Reviewed-on: https://chromium-review.googlesource.com/c/1358920
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#10}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment