New issue
Advanced search Search tips

Issue 910319 link

Starred by 1 user
Status: Fixed
Owner:
smaier@chromium.org
Closed: Nov 30
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 892644


Sign in to add a comment

Use min-api in R8

Project Member Reported by smaier@chromium.org, Nov 29 
The --min-api flag allows R8 to do more and use a newer dex format. Unfortunately, we can't do that until method_count.py works with the new dex format.

Comment 1 by smaier@chromium.org, Nov 29

Blockedon: 892644
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33264a733afc1b040479aa7172018c3c2cf42505

commit 33264a733afc1b040479aa7172018c3c2cf42505
Author: Sam Maier <smaier@chromium.org>
Date: Thu Nov 29 22:11:07 2018

Android: removing min-api from R8

Bug:  910319 
Change-Id: I5fa81395b39d877e68eb8a49a3d4d1ffab016a39
Reviewed-on: https://chromium-review.googlesource.com/c/1355855
Commit-Queue: Sam Maier <smaier@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612398}
[modify] https://crrev.com/33264a733afc1b040479aa7172018c3c2cf42505/build/android/gyp/proguard.py
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f1d894292884ebc41ac1a9d5ae75209d411f5b8

commit 8f1d894292884ebc41ac1a9d5ae75209d411f5b8
Author: Sam Maier <smaier@chromium.org>
Date: Fri Nov 30 21:58:45 2018

Revert "Android: removing min-api from R8"

This reverts commit 33264a733afc1b040479aa7172018c3c2cf42505.

Reason for revert: Since dexdump version has been fixed, this should
now be okay.

Original change's description:
> Android: removing min-api from R8
>
> Bug:  910319 
> Change-Id: I5fa81395b39d877e68eb8a49a3d4d1ffab016a39
> Reviewed-on: https://chromium-review.googlesource.com/c/1355855
> Commit-Queue: Sam Maier <smaier@chromium.org>
> Commit-Queue: agrieve <agrieve@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612398}

TBR=agrieve@chromium.org,smaier@chromium.org

Change-Id: Ie31442be0997e04bfcc65a852446e8935d6e2702
Bug:  910319 
Reviewed-on: https://chromium-review.googlesource.com/c/1357379
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612806}
[modify] https://crrev.com/8f1d894292884ebc41ac1a9d5ae75209d411f5b8/build/android/gyp/dex.py
[modify] https://crrev.com/8f1d894292884ebc41ac1a9d5ae75209d411f5b8/build/android/gyp/proguard.py

Comment 4 by smaier@chromium.org, Nov 30

Status: Fixed (was: Assigned)
►

Sign in to add a comment