unrar: Generate the patch file for changes we've made |
||
Issue descriptionFor any changes we make to code in third_party/ we should have separate patches for each change so that future integrations are easier. I did not do this for unrar when started using unrar because I wasn't aware of this practice.
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46b32b1fc8d96881b11c7f30946020c2a0516f38 commit 46b32b1fc8d96881b11c7f30946020c2a0516f38 Author: Daniel Rubery <drubery@chromium.org> Date: Fri Nov 30 22:36:43 2018 Add a patch file detailing the changes to unrar that fixed linter warnings This CL only includes the changes that made no functional changes to unrar. If diffs from this patch file don't apply to new versions, it shouldn't be very concerning. Bug: 910302 Change-Id: I871307b441a73ba6ee55601ac2944df3eeff7705 Reviewed-on: https://chromium-review.googlesource.com/c/1357383 Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#612825} [add] https://crrev.com/46b32b1fc8d96881b11c7f30946020c2a0516f38/third_party/unrar/patches/001_linter.patch
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19488e50b13612b6b7b59832e002c4d155b8fd43 commit 19488e50b13612b6b7b59832e002c4d155b8fd43 Author: Daniel Rubery <drubery@chromium.org> Date: Tue Dec 04 19:41:08 2018 Add patch for functional changes to unrar This CL adds a patch file detailing the functional changes made to unrar within the Chromium source. Bug: 910302 Change-Id: I6546759ca482a0f3baa9f2166cb41d1214f1bf6b Reviewed-on: https://chromium-review.googlesource.com/c/1357214 Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#613651} [add] https://crrev.com/19488e50b13612b6b7b59832e002c4d155b8fd43/third_party/unrar/patches/002_functional.patch
,
Dec 4
|
||
►
Sign in to add a comment |
||
Comment 1 by vakh@chromium.org
, Nov 29