New issue
Advanced search Search tips

Issue 910297 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 30
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: animations/animationworklet/worklet-animation-currentTime.html



Sign in to add a comment

animations/animationworklet/worklet-animation-currentTime.html is flaky

Project Member Reported by Findit, Nov 29

Issue description


Flaky test: animations/animationworklet/worklet-animation-currentTime.html
Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/26949
Test output log: https://chromium-swarm.appspot.com/task?id=417986adb5c06910
Culprit (87.4% confidence): r612238
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyzgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKXAWNocm9taXVtLndlYmtpdC9XZWJLaXQgTGludXggVHJ1c3R5IExlYWsvMjY5NDkvd2Via2l0X2xheW91dF90ZXN0cy9ZVzVwYldGMGFXOXVjeTloYm1sdFlYUnBiMjUzYjNKcmJHVjBMM2R2Y210c1pYUXRZVzVwYldGMGFXOXVMV04xY25KbGJuUlVhVzFsTG1oMGJXdz0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20animations/animationworklet/worklet-animation-currentTime.html&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyzgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKXAWNocm9taXVtLndlYmtpdC9XZWJLaXQgTGludXggVHJ1c3R5IExlYWsvMjY5NDkvd2Via2l0X2xheW91dF90ZXN0cy9ZVzVwYldGMGFXOXVjeTloYm1sdFlYUnBiMjUzYjNKcmJHVjBMM2R2Y210c1pYUXRZVzVwYldGMGFXOXVMV04xY25KbGJuUlVhVzFsTG1oMGJXdz0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
 
Owner: hirosh...@chromium.org
Status: Started (was: Untriaged)
Looks like just because newly added TestExpectation doesn't cover Linux Leak bot.
Cc: yigu@chromium.org
Cc: -yigu@chromium.org hirosh...@chromium.org
Owner: yigu@chromium.org
Oh, this is worklet-animation-currentTime.html
which is mentioned by the commit message of the culprit CL,
but the test marked as flaky by the culprit CL is worklet-animation-local-time-after-duration.html.

yigu@, could you take a look?

Status: Assigned (was: Started)
Status: Started (was: Assigned)
Shame on me marking the wrong test. Will fix it right away.
Cc: yigu@chromium.org
 Issue 910295  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96ea470027c441ada9b8ff14372f7e422650afc8

commit 96ea470027c441ada9b8ff14372f7e422650afc8
Author: Yi Gu <yigu@chromium.org>
Date: Thu Nov 29 22:19:34 2018

[animationworklet] Mark worklet-animation-currentTime.html as flaky

In crrev.com/c/1343558 I incorrectly marked an innocent test as flaky.

TBR=hiroshige@chromium.org

Bug:  910297 
Change-Id: Ide4bd6e50c4a4a89f577367d640939efedbb30df
Reviewed-on: https://chromium-review.googlesource.com/c/1355776
Reviewed-by: Yi Gu <yigu@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612402}
[modify] https://crrev.com/96ea470027c441ada9b8ff14372f7e422650afc8/third_party/blink/web_tests/TestExpectations

Status: Fixed (was: Started)

Sign in to add a comment