New issue
Advanced search Search tips

Issue 910296 link

Starred by 1 user
Status: Started
Owner:
mattreynolds@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Gamepad vibration for HID gamepads

Project Member Reported by mattreynolds@chromium.org, Nov 29 
Vibration does not work on several HID gamepads that support vibration on other platforms.

When a device supports vibration through a HID output report, and the output report is simple enough that we can construct and send it without any knowledge of the gamepad state, then we should be able to construct a simple vibration output report and send it to the device.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fc983834f3a284ce2a62fa7288b9a5c376a877f

commit 5fc983834f3a284ce2a62fa7288b9a5c376a877f
Author: Matt Reynolds <mattreynolds@google.com>
Date: Fri Nov 30 04:15:07 2018

Add generic vibration support for HID gamepads

Adds HidHapticGamepadBase and platform-specific implementations for
win/mac/linux. HidHapticGamepadBase allows HID gamepads with simple
output reports to handle vibration commands generated through the
Gamepad API.

BUG=910296

Change-Id: I38fa4d4ee1f14ccf94fafd88d400aac869d00195
Reviewed-on: https://chromium-review.googlesource.com/c/1354650
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Ovidio Henriquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612559}
[modify] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/BUILD.gn
[modify] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/gamepad/BUILD.gn
[modify] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/gamepad/gamepad_device_linux.cc
[modify] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/gamepad/gamepad_device_linux.h
[modify] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/gamepad/gamepad_device_mac.h
[modify] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/gamepad/gamepad_device_mac.mm
[modify] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/gamepad/gamepad_service.cc
[modify] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/gamepad/gamepad_standard_mappings_linux.cc
[modify] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/gamepad/gamepad_standard_mappings_mac.mm
[modify] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/gamepad/gamepad_standard_mappings_win.cc
[add] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/gamepad/hid_haptic_gamepad_base.cc
[add] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/gamepad/hid_haptic_gamepad_base.h
[add] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/gamepad/hid_haptic_gamepad_base_unittest.cc
[add] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/gamepad/hid_haptic_gamepad_linux.cc
[add] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/gamepad/hid_haptic_gamepad_linux.h
[add] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/gamepad/hid_haptic_gamepad_mac.cc
[add] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/gamepad/hid_haptic_gamepad_mac.h
[add] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/gamepad/hid_haptic_gamepad_win.cc
[add] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/gamepad/hid_haptic_gamepad_win.h
[modify] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/gamepad/raw_input_gamepad_device_win.cc
[modify] https://crrev.com/5fc983834f3a284ce2a62fa7288b9a5c376a877f/device/gamepad/raw_input_gamepad_device_win.h
►

Sign in to add a comment