Issue metadata
Sign in to add a comment
|
animations/animationworklet/worklet-animation-currentTime.html failing consitently |
||||||||||||||||||||||
Issue descriptionIt has failed the last 3 times it was ran. I think it's because of https://chromium-review.googlesource.com/c/chromium/src/+/1343558 I'll update the expecation for now. Sample builds: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/26951 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/26950 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/26949
,
Nov 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81b9c8b400c181a20f442475eb1e4d8e3e4c0a32 commit 81b9c8b400c181a20f442475eb1e4d8e3e4c0a32 Author: sebsg <sebsg@chromium.org> Date: Thu Nov 29 22:24:43 2018 [Sheriff] Update expecations for worklet-animation-currentTime.html Tbr: yigu@chromium.org Bug: 910295 Change-Id: If17745e818bad3224122ab99c6c63e2a1c084290 Reviewed-on: https://chromium-review.googlesource.com/c/1355255 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#612406} [modify] https://crrev.com/81b9c8b400c181a20f442475eb1e4d8e3e4c0a32/third_party/blink/web_tests/TestExpectations
,
Nov 29
Hi sebsg@, I've already marked the test flaky after duplicating the bug. The test fails on release build but passes on debug ones due to the linked bug in the test expectation. Could you please revert the patch per #2?
,
Nov 29
Sure, thanks for fixing!
,
Nov 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53095cfc182d5ddec83ca8f04cbf96ac21f45a7d commit 53095cfc182d5ddec83ca8f04cbf96ac21f45a7d Author: Sebastien Seguin-Gagnon <sebsg@chromium.org> Date: Thu Nov 29 22:46:49 2018 Revert "[Sheriff] Update expecations for worklet-animation-currentTime.html" This reverts commit 81b9c8b400c181a20f442475eb1e4d8e3e4c0a32. Reason for revert: Owner landed a fix at the same time. Original change's description: > [Sheriff] Update expecations for worklet-animation-currentTime.html > > Tbr: yigu@chromium.org > Bug: 910295 > Change-Id: If17745e818bad3224122ab99c6c63e2a1c084290 > Reviewed-on: https://chromium-review.googlesource.com/c/1355255 > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612406} TBR=sebsg@chromium.org Change-Id: I003b62c838453c6ce1a7df9787ace6bc372f1988 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910295 Reviewed-on: https://chromium-review.googlesource.com/c/1355987 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#612415} [modify] https://crrev.com/53095cfc182d5ddec83ca8f04cbf96ac21f45a7d/third_party/blink/web_tests/TestExpectations |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by yigu@chromium.org
, Nov 29Status: Duplicate (was: Assigned)