New issue
Advanced search Search tips

Issue 910280 link

Starred by 1 user
Status: Fixed
Owner:
jamescook@chromium.org
Closed: Dec 4
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Introduce AXEventBundleSink interface

Project Member Reported by jamescook@chromium.org, Nov 29 
See go/mash-ax

Define a simple interface like AXEventBundleSink or something like that, and have AutomationEventRouter implement it and convert to the extension messages internally. Then AutomationManagerAura doesn't need to depend on any extension-specific IPCs and that makes testing easier.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9760426c81975ec921a7d4b022bcc4dae210ec65

commit 9760426c81975ec921a7d4b022bcc4dae210ec65
Author: James Cook <jamescook@chromium.org>
Date: Tue Dec 04 00:22:06 2018

Add ui::AXEventBundleSink interface for accessibility

This breaks a dependency from AutomationManagerAura to the extensions
system. It should make AutomationManagerAura easier to test in unit
tests.

Bug:  910280 
Test: browser_tests
Change-Id: I3e7036671d6e6140b6e19b72e7d6482e2fb6f376
Reviewed-on: https://chromium-review.googlesource.com/c/1357548
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613347}
[modify] https://crrev.com/9760426c81975ec921a7d4b022bcc4dae210ec65/chrome/browser/extensions/api/automation_internal/automation_event_router.cc
[modify] https://crrev.com/9760426c81975ec921a7d4b022bcc4dae210ec65/chrome/browser/extensions/api/automation_internal/automation_event_router.h
[modify] https://crrev.com/9760426c81975ec921a7d4b022bcc4dae210ec65/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/9760426c81975ec921a7d4b022bcc4dae210ec65/chrome/browser/ui/aura/accessibility/automation_manager_aura.h
[modify] https://crrev.com/9760426c81975ec921a7d4b022bcc4dae210ec65/chrome/browser/ui/aura/accessibility/automation_manager_aura_browsertest.cc
[modify] https://crrev.com/9760426c81975ec921a7d4b022bcc4dae210ec65/ui/accessibility/BUILD.gn
[add] https://crrev.com/9760426c81975ec921a7d4b022bcc4dae210ec65/ui/accessibility/ax_event_bundle_sink.h

Comment 2 by jamescook@chromium.org, Dec 4

Status: Fixed (was: Started)
►

Sign in to add a comment