New issue
Advanced search Search tips

Issue 910279 link

Starred by 1 user
Status: Fixed
Owner:
beccahughes@chromium.org
Closed: Dec 20
Cc:
chrome-media-session-dev@google.com
beccahughes@chromium.org
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 902519



Sign in to add a comment

Use is_controllable to determine active media session

Project Member Reported by beccahughes@chromium.org, Nov 29 
The active media session is currently the top most gain session. This is the session that will receive control commands. We should move this to a dedicated "is controllable" attribute on media session. We will break this down into the following subtasks:

1) Add is_controllable to mojo and use for active media controller
2) Add is_controllable to MediaSessionImpl
3) Convert old IsControllable() uses to mojo
4) Add support to ARC++

Comment 1 by beccahughes@chromium.org, Nov 30

Summary: Use is_controllable to determine active media session (was: Use is_controllable to determine activ e media session)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9fdace3a05e5aad47641994c8a6d2a51451a3d4

commit b9fdace3a05e5aad47641994c8a6d2a51451a3d4
Author: Becca Hughes <beccahughes@chromium.org>
Date: Tue Dec 04 19:25:35 2018

[Media Session] Add is controllable and use that for active

Add an is_controllable boolean that allows media sessions
to decide whether they should be controlled or not. We
should then use that to decide the active controller.

BUG= 910279 

Change-Id: Ib98a7091ea67b76ae81b593f633d6219a28ea633
Reviewed-on: https://chromium-review.googlesource.com/c/1357622
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613634}
[modify] https://crrev.com/b9fdace3a05e5aad47641994c8a6d2a51451a3d4/services/media_session/audio_focus_manager.cc
[modify] https://crrev.com/b9fdace3a05e5aad47641994c8a6d2a51451a3d4/services/media_session/audio_focus_manager_unittest.cc
[modify] https://crrev.com/b9fdace3a05e5aad47641994c8a6d2a51451a3d4/services/media_session/controlling_media_playback.md
[modify] https://crrev.com/b9fdace3a05e5aad47641994c8a6d2a51451a3d4/services/media_session/media_controller_unittest.cc
[modify] https://crrev.com/b9fdace3a05e5aad47641994c8a6d2a51451a3d4/services/media_session/public/cpp/test/mock_media_session.cc
[modify] https://crrev.com/b9fdace3a05e5aad47641994c8a6d2a51451a3d4/services/media_session/public/cpp/test/mock_media_session.h
[modify] https://crrev.com/b9fdace3a05e5aad47641994c8a6d2a51451a3d4/services/media_session/public/mojom/media_session.mojom

Comment 5 by beccahughes@google.com, Dec 20

Status: Fixed (was: Assigned)
►

Sign in to add a comment