New issue
Advanced search Search tips

Issue 910263 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 4
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Couple of layout tests fail on Mac.

Project Member Reported by se...@chromium.org, Nov 29

Issue description

* css1/font_properties/font.html
* css1/font_properties/font_family.html
* css2.1/t1503-c522-font-family-00-b.html
* css2.1/t1508-c527-font-03-b.html
* fast/block/float/016.html
* fast/text/international/complex-character-based-fallback.html
* fonts/cursive.html
* svg/text/ligature-queries.html

These are likely due to harfbuzz

I'll update the expectations in the meantime.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7040acdffe5c67d0c93c62442bd3d084a8c03ae7

commit 7040acdffe5c67d0c93c62442bd3d084a8c03ae7
Author: sebsg <sebsg@chromium.org>
Date: Thu Nov 29 20:49:47 2018

[Sheriff] Disable a couple of LayoutTests on Mac.

There were failing.
* css1/font_properties/font.html
* css1/font_properties/font_family.html
* css2.1/t1503-c522-font-family-00-b.html
* css2.1/t1508-c527-font-03-b.html
* fast/block/float/016.html
* fast/text/international/complex-character-based-fallback.html
* fonts/cursive.html
* svg/text/ligature-queries.html

Tbr: drott@chromium.org
Bug:  910263 
Change-Id: If5a9291579bff7d8c3184a8c02813088df6c06f5
Reviewed-on: https://chromium-review.googlesource.com/c/1355523
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612346}
[modify] https://crrev.com/7040acdffe5c67d0c93c62442bd3d084a8c03ae7/third_party/blink/web_tests/TestExpectations

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cbe44c3bd8f964cb5879127f6acff1d18a756d0

commit 8cbe44c3bd8f964cb5879127f6acff1d18a756d0
Author: Ovidio Henriquez <odejesush@chromium.org>
Date: Mon Dec 03 21:23:37 2018

[Sheriff] Disable fast/test/small-caps-aat.html

The small-caps-aat.html was failing on the WebKit Mac10.13 (retina)
builder.

Tbr: drott@chromium.org
Bug:  910263 
Change-Id: Idbe95ab8055f53b777c03c7e6a5d283abf691074
Reviewed-on: https://chromium-review.googlesource.com/c/1359063
Reviewed-by: Ovidio Henriquez <odejesush@chromium.org>
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613249}
[modify] https://crrev.com/8cbe44c3bd8f964cb5879127f6acff1d18a756d0/third_party/blink/web_tests/TestExpectations

Cc: odejesush@chromium.org
odejesush@, re #3, do you have a link to the test results? On the 10.13 and 10.13-retina trybots this test passes just fine - do we have a case of font-specific flakiness due to build-version differences of the Mac images?

Perhaps the backlog is not long enough, I am unable to find these failures from https://ci.chromium.org/p/chromium/g/chromium.mac/console - hence a link would be helpful.


Project Member

Comment 6 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75ecd766fa091eb54c91a00decd702562fd0c79c

commit 75ecd766fa091eb54c91a00decd702562fd0c79c
Author: Dominik Röttsches <drott@chromium.org>
Date: Tue Dec 04 10:51:41 2018

Remove lines from TestExpectations

To sheriffs, if fast/test/small-caps-aat.html fails again, see comment 3
of the bug, please provide a link to the failing builds and disable it
with reference to  issue 910263 . This might be a case of font-specific
flakiness, as this test passes on the 10.13 and 10.13 retina trybots -
thank you!

Tbr: sebsg@chromium.org
Bug:  910263 
Change-Id: Ic93a7108d3a3187bde3e2a58d2c01a363c6f1a3e
Reviewed-on: https://chromium-review.googlesource.com/c/1360277
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613500}
[modify] https://crrev.com/75ecd766fa091eb54c91a00decd702562fd0c79c/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/75ecd766fa091eb54c91a00decd702562fd0c79c/third_party/blink/web_tests/platform/mac-mac10.10/css1/font_properties/font_family-expected.png
[modify] https://crrev.com/75ecd766fa091eb54c91a00decd702562fd0c79c/third_party/blink/web_tests/platform/mac-mac10.10/css2.1/t1503-c522-font-family-00-b-expected.png
[delete] https://crrev.com/c3f610bc020c876ddb1d31f7037e8890cc986488/third_party/blink/web_tests/platform/mac-mac10.10/transforms/shadows-expected.png
[modify] https://crrev.com/75ecd766fa091eb54c91a00decd702562fd0c79c/third_party/blink/web_tests/platform/mac-mac10.11/css1/font_properties/font_family-expected.png
[modify] https://crrev.com/75ecd766fa091eb54c91a00decd702562fd0c79c/third_party/blink/web_tests/platform/mac-mac10.11/css2.1/t1503-c522-font-family-00-b-expected.png
[modify] https://crrev.com/75ecd766fa091eb54c91a00decd702562fd0c79c/third_party/blink/web_tests/platform/mac-mac10.12/css1/font_properties/font-expected.png
[modify] https://crrev.com/75ecd766fa091eb54c91a00decd702562fd0c79c/third_party/blink/web_tests/platform/mac-mac10.12/fonts/cursive-expected.png
[modify] https://crrev.com/75ecd766fa091eb54c91a00decd702562fd0c79c/third_party/blink/web_tests/platform/mac-mac10.12/svg/text/ligature-queries-expected.png
[modify] https://crrev.com/75ecd766fa091eb54c91a00decd702562fd0c79c/third_party/blink/web_tests/platform/mac/css1/font_properties/font-expected.png
[modify] https://crrev.com/75ecd766fa091eb54c91a00decd702562fd0c79c/third_party/blink/web_tests/platform/mac/css1/font_properties/font_family-expected.png
[modify] https://crrev.com/75ecd766fa091eb54c91a00decd702562fd0c79c/third_party/blink/web_tests/platform/mac/css2.1/t1503-c522-font-family-00-b-expected.png
[modify] https://crrev.com/75ecd766fa091eb54c91a00decd702562fd0c79c/third_party/blink/web_tests/platform/mac/css2.1/t1508-c527-font-03-b-expected.png
[modify] https://crrev.com/75ecd766fa091eb54c91a00decd702562fd0c79c/third_party/blink/web_tests/platform/mac/fast/block/float/016-expected.png
[modify] https://crrev.com/75ecd766fa091eb54c91a00decd702562fd0c79c/third_party/blink/web_tests/platform/mac/fast/text/international/complex-character-based-fallback-expected.png
[modify] https://crrev.com/75ecd766fa091eb54c91a00decd702562fd0c79c/third_party/blink/web_tests/platform/mac/fonts/cursive-expected.png
[modify] https://crrev.com/75ecd766fa091eb54c91a00decd702562fd0c79c/third_party/blink/web_tests/platform/mac/svg/text/ligature-queries-expected.png

Status: Fixed (was: Assigned)

Sign in to add a comment